script: Fix handling changes to relevant attributes for stylesheets by TimvdLippe · Pull Request #42273 · servo/servo

TimvdLippe · 2026-02-01T14:47:47Z

We weren't removing stylesheets when we should be doing so. This most notably happens when the stylesheet no longer has a href or its "rel" changes.

The crash is also fixed, since the issue was that we were passing the value of the attribute that was changed as if it were an href. However, if we set the type attribute, then that's not the href.

To fix that, we now retrieve the href inside the method so we always have the correct value.

Fixes #42259

github-actions · 2026-02-01T14:48:01Z

🔨 Triggering try run (#21564819094) for Linux (WPT)

servo-wpt-sync · 2026-02-01T14:50:52Z

🤖 Opened new upstream WPT pull request (web-platform-tests/wpt#57469) with upstreamable changes.

github-actions · 2026-02-01T14:50:55Z

⚠️ Try run (#21564819094) failed!

github-actions · 2026-02-01T17:10:04Z

🔨 Triggering try run (#21566873079) for Linux (WPT)

servo-wpt-sync · 2026-02-01T17:12:52Z

📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#57469).

github-actions · 2026-02-01T17:40:46Z

Test results for linux-wpt from try job (#21566873079):

Flaky unexpected result (37)

OK /FileAPI/file/send-file-form-utf-8.html

FAIL [expected PASS] subtest: Upload file-for-upload-in-form-.txt (x-user-defined) in UTF-8 form

assert_greater_than: file-for-upload-in-form-.txt: multipart form data must have at least 3 lines: "" expected a number greater than 2 but got 0

TIMEOUT /FileAPI/url/url-in-tags-revoke.window.html (#19978)
- TIMEOUT [expected PASS] subtest: Fetching a blob URL immediately before revoking it works in <script> tags.
```
Test timed out
```
OK /IndexedDB/idbfactory-open-error-properties.any.html
- PASS [expected FAIL] subtest: Properties of error event from failed open()
OK /IndexedDB/idbfactory-open-error-properties.any.worker.html
- PASS [expected FAIL] subtest: Properties of error event from failed open()
OK /_mozilla/mozilla/getBoundingClientRect.html (#39668)
- FAIL [expected PASS] subtest: getBoundingClientRect 1
```
assert_equals: expected 62 but got 60.35
```
CRASH [expected PASS] /_mozilla/shadow-dom/move-element-with-ua-shadow-tree-crash.html (#39473)
TIMEOUT [expected OK] /_webgl/conformance/canvas/canvas-zero-size.html
OK /beacon/beacon-basic.https.window.html (#41723)
- FAIL [expected PASS] subtest: Payload size restriction should be accumulated: type = string
```
assert_false: expected false got true
```
OK /content-security-policy/frame-ancestors/frame-ancestors-path-ignored.window.html (#36468)
- PASS [expected FAIL] subtest: A 'frame-ancestors' CSP directive with a URL that includes a path should be ignored.
TIMEOUT [expected PASS] /css/CSS2/normal-flow/block-replaced-width-006.xht
OK /css/css-cascade/layer-cssom-order-reverse.html (#36094)
- PASS [expected FAIL] subtest: Delete layer invalidates @font-face
OK /css/css-fonts/generic-family-keywords-003.html (#38994)
- PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted math (drawing text in a canvas)
- PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted generic(nastaliq) (drawing text in a canvas)
- PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted ui-monospace (drawing text in a canvas)
OK /css/css-fonts/variations/at-font-face-font-matching.html (#20684)
- FAIL [expected PASS] subtest: Matching font-style: 'oblique -21deg' should prefer 'oblique -21deg' over 'oblique -60deg -40deg'
```
assert_equals: Unexpected font on test element expected 487 but got 532
```
OK /css/css-grid/grid-definition/grid-support-flexible-lengths-001.html
- FAIL [expected PASS] subtest: 'grid' with: grid-template-columns: auto 1fr 4fr 3fr 2fr; and grid-template-rows: auto 1fr 4fr 3fr 2fr;
```
assert_in_array: gridTemplateColumns value "59px 74.1px 296.4px 222.3px 148.2px" not in array ["90px 71px 284px 213px 142px"]
```
- FAIL [expected PASS] subtest: 'grid' with: grid-template-columns: auto 1fr; and grid-template-rows: auto 1fr;
```
assert_in_array: gridTemplateColumns value "59px 741px" not in array ["90px 710px"]
```
- FAIL [expected PASS] subtest: 'grid' with: grid-template-columns: max-content 1fr; and grid-template-rows: max-content 1fr;
```
assert_in_array: gridTemplateColumns value "59px 741px" not in array ["90px 710px"]
```
- FAIL [expected PASS] subtest: 'grid' with: grid-template-columns: min-content 1fr; and grid-template-rows: min-content 1fr;
```
assert_in_array: gridTemplateColumns value "28px 772px" not in array ["40px 760px"]
```
- FAIL [expected PASS] subtest: 'grid' with: grid-template-columns: fr; and grid-template-rows: fr;
```
assert_in_array: gridTemplateColumns value "59px" not in array ["90px"]
```
- FAIL [expected PASS] subtest: 'grid' with: grid-template-columns: 1 fr; and grid-template-rows: 1 fr;
```
assert_in_array: gridTemplateColumns value "59px" not in array ["90px"]
```
- FAIL [expected PASS] subtest: 'grid' with: grid-template-columns: 1free-space; and grid-template-rows: 1free-space;
```
assert_in_array: gridTemplateColumns value "59px" not in array ["90px"]
```
- FAIL [expected PASS] subtest: 'grid' with: grid-template-columns: -2fr; and grid-template-rows: -2fr;
```
assert_in_array: gridTemplateColumns value "59px" not in array ["90px"]
```
- FAIL [expected PASS] subtest: 'grid' with: grid-template-columns: 0,5fr; and grid-template-rows: 0,5fr;
```
assert_in_array: gridTemplateColumns value "59px" not in array ["90px"]
```
- FAIL [expected PASS] subtest: 'grid' with: grid-template-columns: calc(1fr + 100px); and grid-template-rows: calc(1fr + 100px);
```
assert_in_array: gridTemplateColumns value "59px" not in array ["90px"]
```
- And 2 more unexpected results...
CRASH [expected PASS] /css/css-overflow/scroll-marker-in-display-none-column-crash.html
FAIL [expected PASS] /css/css-ui/compute-kind-widget-generated/kind-of-widget-fallback-radio-input-border-end-end-radius-001.html
OK /custom-elements/form-associated/ElementInternals-setFormValue.html (#29174)
- PASS [expected FAIL] subtest: Single value - empty name exists
- PASS [expected FAIL] subtest: Single value - Non-empty name exists
- PASS [expected FAIL] subtest: Null value should submit nothing
ERROR /fetch/metadata/generated/serviceworker.https.sub.html (#36247)
- FAIL [expected PASS] subtest: sec-fetch-site - Same origin, no options - registration
```
promise_test: Unhandled rejection with value: object "Error: Failed to query for recorded headers."
```
CRASH [expected OK] /html/browsers/history/the-history-interface/004.html
OK /html/browsers/history/the-history-interface/traverse_the_history_5.html (#21383)
- PASS [expected FAIL] subtest: Multiple history traversals, last would be aborted
OK /html/semantics/forms/form-submission-0/jsurl-form-submit.tentative.html (#36489)
- PASS [expected FAIL] subtest: Verifies that form submissions scheduled inside javascript: urls take precedence over the javascript: url's return value.
OK /html/semantics/forms/form-submission-0/multipart-formdata.window.html (#28725)
- FAIL [expected PASS] subtest: multipart/form-data: Basic test (formdata event)
```
assert_equals: expected "\r\nContent-Disposition: form-data; name=\"basic\"\r\n\r\ntest\r\n--\r\n" but got ""
```
- FAIL [expected PASS] subtest: multipart/form-data: Basic File test (normal form)
```
assert_equals: expected "\r\nContent-Disposition: form-data; name=\"basic\"; filename=\"file-test.txt\"\r\nContent-Type: text/plain\r\n\r\n\r\n--\r\n" but got ""
```
- PASS [expected FAIL] subtest: multipart/form-data: Basic File test (formdata event)
- PASS [expected FAIL] subtest: multipart/form-data: 0x00 in value (formdata event)
OK /html/semantics/forms/form-submission-0/text-plain.window.html (#28687)
- FAIL [expected PASS] subtest: text/plain: Basic File test (normal form)
```
assert_equals: expected "basic=file-test.txt\r\n" but got ""
```
- PASS [expected FAIL] subtest: text/plain: 0x00 in name (normal form)
- PASS [expected FAIL] subtest: text/plain: 0x00 in value (formdata event)
- PASS [expected FAIL] subtest: text/plain: single quote in name (normal form)
OK /html/semantics/forms/form-submission-0/urlencoded2.window.html (#28687)
- FAIL [expected PASS] subtest: application/x-www-form-urlencoded: Basic test (formdata event)
```
assert_equals: expected "basic=test" but got ""
```
- PASS [expected FAIL] subtest: application/x-www-form-urlencoded: 0x00 in value (formdata event)
- PASS [expected FAIL] subtest: application/x-www-form-urlencoded: double quote in name (formdata event)
OK [expected ERROR] /html/user-activation/no-activation-thru-escape-key.html (#40343)
CRASH [expected OK] /html/webappapis/scripting/processing-model-2/runtime-error-same-origin-with-hash.html
CRASH [expected OK] /intersection-observer/v2/simple-effects.html
OK [expected CRASH] /resource-timing/render-blocking-status-link.html (#41664)
OK /touch-events/single-tap-when-touchend-listener-use-sync-xhr.html (#41175)
- PASS [expected FAIL] subtest: Click event should be fired when touchend opens synchronous XHR
TIMEOUT /trusted-types/trusted-types-navigation.html?06-10 (#37920)
- TIMEOUT [expected FAIL] subtest: Navigate a frame via anchor with javascript:-urls in report-only mode.
```
Test timed out
```
- NOTRUN [expected TIMEOUT] subtest: Navigate a frame via anchor with javascript:-urls w/ default policy in report-only mode.
OK [expected TIMEOUT] /trusted-types/trusted-types-navigation.html?31-35 (#38034)
- PASS [expected TIMEOUT] subtest: Navigate a frame via form-submission with javascript:-urls w/ default policy in report-only mode.
- FAIL [expected NOTRUN] subtest: Navigate a window via form-submission with javascript:-urls w/ a default policy throwing an exception in enforcing mode.
```
promise_test: Unhandled rejection with value: "Unexpected message received: \"No securitypolicyviolation reported!\""
```
- FAIL [expected NOTRUN] subtest: Navigate a window via form-submission with javascript:-urls w/ a default policy throwing an exception in report-only mode.
```
promise_test: Unhandled rejection with value: "Unexpected message received: \"No securitypolicyviolation reported!\""
```
- FAIL [expected NOTRUN] subtest: Navigate a window via form-submission with javascript:-urls w/ a default policy making the URL invalid in enforcing mode.
```
promise_test: Unhandled rejection with value: "Unexpected message received: \"No securitypolicyviolation reported!\""
```
OK /visual-viewport/resize-event-order.html (#41981)
- PASS [expected FAIL] subtest: Popup: DOMWindow resize fired before VisualViewport.
OK [expected TIMEOUT] /webmessaging/without-ports/017.html (#24486)
- PASS [expected TIMEOUT] subtest: origin of the script that invoked the method, about:blank
TIMEOUT [expected OK] /webstorage/localstorage-about-blank-3P-iframe-opens-3P-window.partitioned.html (#29053)
- TIMEOUT [expected PASS] subtest: StorageKey: test 3P about:blank window opened from a 3P iframe
```
Test timed out
```
CRASH [expected OK] /webstorage/storage_builtins.window.html
OK [expected ERROR] /webxr/render_state_update.https.html (#27535)
CRASH [expected OK] /workers/Worker-timeout-decreasing-order.html

Stable unexpected results that are known to be intermittent (27)

OK /FileAPI/url/url-with-fetch.any.worker.html (#21517)
- FAIL [expected PASS] subtest: Revoke blob URL after calling fetch, fetch should succeed
```
promise_test: Unhandled rejection with value: object "TypeError: Network error: Blob URL store error: InvalidFileID"
```

OK /IndexedDB/idbcursor-continuePrimaryKey-exceptions.any.html (#39277)

FAIL [expected PASS] subtest: IDBCursor continuePrimaryKey() on object store cursor

assert_throws_dom: continuePrimaryKey() should throw if source is not an index function "function() {
        cursor.continuePrimaryKey(2, 2);
      }" threw object "TypeError: cursor.continuePrimaryKey is not a function" that is not a DOMException InvalidAccessError: property "code" is equal to undefined, expected 15

OK /IndexedDB/idbcursor-continuePrimaryKey-exceptions.any.worker.html (#39277)

FAIL [expected PASS] subtest: IDBCursor continuePrimaryKey() on object store cursor

assert_throws_dom: continuePrimaryKey() should throw if source is not an index function "function() {
        cursor.continuePrimaryKey(2, 2);
      }" threw object "TypeError: cursor.continuePrimaryKey is not a function" that is not a DOMException InvalidAccessError: property "code" is equal to undefined, expected 15

OK /IndexedDB/idbobjectstore_getAll.any.html (#39276)
- PASS [expected FAIL] subtest: Get all values with transaction.commit()
OK /IndexedDB/idbobjectstore_getAll.any.worker.html (#39400)
- PASS [expected FAIL] subtest: Get all values with transaction.commit()
OK /IndexedDB/idbrequest-onupgradeneeded.any.html (#38895)
- PASS [expected FAIL] subtest: transaction oncomplete ordering relative to open request onsuccess
OK /IndexedDB/idbrequest-onupgradeneeded.any.worker.html (#38971)
- PASS [expected FAIL] subtest: transaction oncomplete ordering relative to open request onsuccess

OK /IndexedDB/key-conversion-exceptions.any.html (#39305)

FAIL [expected PASS] subtest: IDBCursor continue() method with throwing/invalid keys

assert_throws_exactly: key conversion with throwing getter should rethrow function "() =&gt; {
      receiver[method](key);
    }" threw object "TypeError: receiver[method] is not a function" but we expected it to throw object "getter: throwing from getter"

FAIL [expected PASS] subtest: IDBCursor update() method with throwing/invalid keys

assert_throws_exactly: throwing getter should rethrow during clone function "() =&gt; {
      cursor.update(value);
    }" threw object "TypeError: cursor.update is not a function" but we expected it to throw object "getter: throwing from getter"

OK /IndexedDB/key-conversion-exceptions.any.worker.html (#39284)

FAIL [expected PASS] subtest: IDBCursor continue() method with throwing/invalid keys

assert_throws_exactly: key conversion with throwing getter should rethrow function "() =&gt; {
      receiver[method](key);
    }" threw object "TypeError: receiver[method] is not a function" but we expected it to throw object "getter: throwing from getter"

FAIL [expected PASS] subtest: IDBCursor update() method with throwing/invalid keys

assert_throws_exactly: throwing getter should rethrow during clone function "() =&gt; {
      cursor.update(value);
    }" threw object "TypeError: cursor.update is not a function" but we expected it to throw object "getter: throwing from getter"

FAIL [expected PASS] /_mozilla/mozilla/sslfail.html (#10760)
TIMEOUT [expected OK] /_mozilla/mozilla/window_resize_event.html (#36741)
- TIMEOUT [expected PASS] subtest: Popup onresize event fires after resizeTo
```
Test timed out
```
OK /css/css-cascade/layer-font-face-override.html (#35935)
- PASS [expected FAIL] subtest: @font-face override update with appended sheet 1
OK /css/css-fonts/generic-family-keywords-002.html (#40929)
- FAIL [expected PASS] subtest: font-family: -webkit-serif treated as <font-family>, not <generic-name>
```
assert_equals: expected 30 but got 50
```
- FAIL [expected PASS] subtest: font-family: -webkit-sans-serif treated as <font-family>, not <generic-name>
```
assert_equals: expected 30 but got 50
```
- FAIL [expected PASS] subtest: font-family: -webkit-cursive treated as <font-family>, not <generic-name>
```
assert_equals: expected 30 but got 50
```
- FAIL [expected PASS] subtest: font-family: -webkit-fantasy treated as <font-family>, not <generic-name>
```
assert_equals: expected 30 but got 50
```
- FAIL [expected PASS] subtest: font-family: -webkit-monospace treated as <font-family>, not <generic-name>
```
assert_equals: expected 30 but got 50
```
- FAIL [expected PASS] subtest: font-family: -webkit-system-ui treated as <font-family>, not <generic-name>
```
assert_equals: expected 30 but got 50
```
- FAIL [expected PASS] subtest: font-family: -webkit-math treated as <font-family>, not <generic-name>
```
assert_equals: expected 30 but got 50
```
- PASS [expected FAIL] subtest: font-family: -webkit-generic(fangsong) treated as <font-family>, not <generic-name>
- PASS [expected FAIL] subtest: font-family: -webkit-generic(kai) treated as <font-family>, not <generic-name>
- PASS [expected FAIL] subtest: font-family: -webkit-generic(khmer-mul) treated as <font-family>, not <generic-name>
- And 12 more unexpected results...
OK /css/cssom-view/offsetTopLeft-border-box.html (#40826)
- PASS [expected FAIL] subtest: container: 0
- PASS [expected FAIL] subtest: container: 1
ERROR [expected OK] /fetch/fetch-later/quota/same-origin-iframe/multiple-iframes.https.window.html (#35176)
OK /fetch/metadata/generated/css-font-face.https.sub.tentative.html (#32732)
- PASS [expected FAIL] subtest: sec-fetch-dest
- FAIL [expected PASS] subtest: sec-fetch-user
```
promise_test: Unhandled rejection with value: object "Error: Failed to query for recorded headers."
```
- PASS [expected FAIL] subtest: sec-fetch-storage-access - Cross-site
OK /fetch/metadata/generated/css-font-face.sub.tentative.html (#34624)
- FAIL [expected PASS] subtest: sec-fetch-storage-access - Not sent to non-trustworthy same-site destination
```
promise_test: Unhandled rejection with value: object "Error: Failed to query for recorded headers."
```
OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/load-pageshow-events-window-open.html (#28691)
- PASS [expected FAIL] subtest: load event does not fire on window.open('about:blank')
OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-cross-origin.sub.window.html (#29056)
- FAIL [expected PASS] subtest: Cross-origin navigation started from unload handler must be ignored
```
promise_test: Unhandled rejection with value: object "SecurityError: The operation is insecure."
```

OK /html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/a-click.html (#28697)

FAIL [expected PASS] subtest: aElement.click() before the load event must NOT replace

assert_equals: expected "http://web-platform.test:8000/common/blank.html?thereplacement" but got "http://web-platform.test:8000/html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/resources/code-injector.html?pipe=sub(none)&amp;code=%0A%20%20%20%20const%20a%20%3D%20document.createElement(%22a%22)%3B%0A%20%20%20%20a.href%20%3D%20%22%2Fcommon%2Fblank.html%3Fthereplacement%22%3B%0A%20%20%20%20document.currentScript.before(a)%3B%0A%20%20%20%20a.click()%3B%0A%20%20"

OK /html/semantics/document-metadata/the-meta-element/pragma-directives/attr-meta-http-equiv-refresh/allow-scripts-flag-changing-2.html (#39703)
- PASS [expected FAIL] subtest: Meta refresh of the original iframe is not blocked if moved into a sandboxed iframe
TIMEOUT /html/semantics/embedded-content/media-elements/autoplay-allowed-by-feature-policy.https.sub.html (#41404)
- TIMEOUT [expected PASS] subtest: Feature-Policy header: autoplay * allows same-origin iframes.
```
Test timed out
```
TIMEOUT /html/semantics/embedded-content/media-elements/autoplay-disabled-by-feature-policy.https.sub.html (#41221)
- TIMEOUT [expected FAIL] subtest: Feature-Policy header: autoplay "none" disallows same-origin iframes.
```
Test timed out
```
OK /html/semantics/embedded-content/media-elements/media_fragment_seek.html (#24114)
- FAIL [expected PASS] subtest: Video should seek to time specified in media fragment syntax
```
assert_equals: expected 3 but got 0
```
OK /navigation-timing/test-navigation-type-reload.html (#33334)
- FAIL [expected PASS] subtest: Reload domComplete > Original domComplete
```
assert_true: Reload domComplete &gt; Original domComplete expected true got false
```
- FAIL [expected PASS] subtest: Reload loadEventEnd > Original loadEventEnd
```
assert_true: Reload loadEventEnd &gt; Original loadEventEnd expected true got false
```
- FAIL [expected PASS] subtest: Reload loadEventStart > Original loadEventStart
```
assert_true: Reload loadEventStart &gt; Original loadEventStart expected true got false
```
OK /resource-timing/test_resource_timing.html (#25720)
- FAIL [expected NOTRUN] subtest: PerformanceEntry has correct name, initiatorType, startTime, and duration (link)
```
assert_equals: expected 10.219999999999999 but got 10.22
```
OK /resource-timing/test_resource_timing.https.html (#25216)
- FAIL [expected PASS] subtest: PerformanceEntry has correct name, initiatorType, startTime, and duration (img)
```
assert_equals: expected 11.030000000000001 but got 11.02
```

Stable unexpected results (2)

OK [expected TIMEOUT] /css/cssom/HTMLLinkElement-disabled-005.html
- PASS [expected TIMEOUT] subtest: HTMLLinkElement.disabled's explicitly enabled state persists regardless of rel
PASS [expected FAIL] /preload/preload-in-data-doc.html

github-actions · 2026-02-01T17:40:53Z

⚠️ Try run (#21566873079) failed!

servo-wpt-sync · 2026-02-01T19:35:47Z

📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#57469).

We weren't removing stylesheets when we should be doing so. This most notably happens when the stylesheet no longer has a href or its "rel" changes. The crash is also fixed, since the issue was that we were passing the value of the attribute that was changed as if it were an href. However, if we set the type attribute, then that's not the href. To fix that, we now retrieve the href inside the method so we always have the correct value. Fixes servo#42259 Signed-off-by: Tim van der Lippe <[email protected]>

servo-wpt-sync · 2026-02-01T19:55:31Z

📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#57469).

components/script/dom/html/htmllinkelement.rs

Signed-off-by: Tim van der Lippe <[email protected]>

servo-wpt-sync · 2026-02-02T08:45:18Z

📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#57469).

Signed-off-by: Tim van der Lippe <[email protected]>

servo-wpt-sync · 2026-02-02T11:02:11Z

📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#57469).

Signed-off-by: Tim van der Lippe <[email protected]>

servo-wpt-sync · 2026-02-02T13:34:03Z

📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#57469).

TimvdLippe requested a review from gterzian as a code owner February 1, 2026 14:47

TimvdLippe added the T-linux-wpt Do a try run of the WPT label Feb 1, 2026

servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Feb 1, 2026

github-actions bot removed the T-linux-wpt Do a try run of the WPT label Feb 1, 2026

TimvdLippe mentioned this pull request Feb 1, 2026

panic: What finished? (thread Script#1, at components/script/dom/html/htmllinkelement.rs:870) #42259

Closed

servo-wpt-sync mentioned this pull request Feb 1, 2026

script: Fix handling changes to relevant attributes for stylesheets web-platform-tests/wpt#57469

Merged

TimvdLippe force-pushed the fix-changing-attributes-for-link-elements branch from 761857d to d4ea74f Compare February 1, 2026 17:09

TimvdLippe added the T-linux-wpt Do a try run of the WPT label Feb 1, 2026

github-actions bot removed the T-linux-wpt Do a try run of the WPT label Feb 1, 2026

TimvdLippe force-pushed the fix-changing-attributes-for-link-elements branch from d4ea74f to b60f230 Compare February 1, 2026 19:32

TimvdLippe force-pushed the fix-changing-attributes-for-link-elements branch from b60f230 to f294b4a Compare February 1, 2026 19:52

mrobinson approved these changes Feb 1, 2026

View reviewed changes

components/script/dom/html/htmllinkelement.rs Show resolved Hide resolved

components/script/dom/html/htmllinkelement.rs Outdated Show resolved Hide resolved

servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Feb 1, 2026

Update htmllinkelement.rs

539ddfa

Signed-off-by: Tim van der Lippe <[email protected]>

servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Feb 2, 2026

TimvdLippe enabled auto-merge February 2, 2026 08:42

Update htmllinkelement.rs

08cd398

Signed-off-by: Tim van der Lippe <[email protected]>

Update htmllinkelement.rs

c5e427d

Signed-off-by: Tim van der Lippe <[email protected]>

TimvdLippe added this pull request to the merge queue Feb 2, 2026

servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Feb 2, 2026

Merged via the queue into servo:main with commit 19c2f93 Feb 2, 2026
29 checks passed

TimvdLippe deleted the fix-changing-attributes-for-link-elements branch February 2, 2026 14:13

servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Feb 2, 2026

Uh oh!

Conversation

TimvdLippe commented Feb 1, 2026

Uh oh!

github-actions bot commented Feb 1, 2026

Uh oh!

servo-wpt-sync commented Feb 1, 2026

Uh oh!

github-actions bot commented Feb 1, 2026

Uh oh!

github-actions bot commented Feb 1, 2026

Uh oh!

servo-wpt-sync commented Feb 1, 2026

Uh oh!

github-actions bot commented Feb 1, 2026

Uh oh!

github-actions bot commented Feb 1, 2026

Uh oh!

servo-wpt-sync commented Feb 1, 2026

Uh oh!

servo-wpt-sync commented Feb 1, 2026

Uh oh!

Uh oh!

Uh oh!

servo-wpt-sync commented Feb 2, 2026

Uh oh!

servo-wpt-sync commented Feb 2, 2026

Uh oh!

servo-wpt-sync commented Feb 2, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants