[26488] Refactors GPUCanvasContext to manage context dropping.#42243
Merged
sagudev merged 1 commit intoservo:mainfrom Jan 29, 2026
Conversation
Moves the `Drop` implementation for `GPUCanvasContext` to a new `DroppableGPUCanvasContext` struct. This ensures the context destruction logic is correctly handled, as the `GPUCanvasContext` struct itself is a DOM struct and should not have a drop implementation. This change aligns with the requirement that DOM types should not implement Drop. Fixes servo#26488 Signed-off-by: Domenico Rizzo <[email protected]>
servo-highfive
added
the
S-awaiting-review
sagudev
approved these changes
Jan 29, 2026
servo-highfive
removed
the
S-awaiting-review
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
willypuzzle
deleted the
26488-Drop-impls-for-DOM-types-should-be-forbidden-GPUCanvasContext
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the
Dropimplementation forGPUCanvasContextto a newDroppableGPUCanvasContextstruct.This ensures the context destruction logic is correctly handled, as the
GPUCanvasContextstruct itself is a DOM struct and should not have a drop implementation. This change aligns with the requirement that DOM types should not implement Drop.Testing: No tests added
Fixes: #26488