layout: Ensure legacy alignment-related presentational hints match specification#42220
Merged
mrobinson merged 1 commit intoservo:mainfrom Jan 28, 2026
Merged
Conversation
…ecification The legacy alignment presentation hints differed from the specification in a way that was breaking them when dealing with `<img>`. The culprit seems to be the selector `img[type = image i]` which seems a little nonsensical. This change makes the CSS in `presentational-hints.css` match what is found in the specification. There is still an issue with "bottom" alignment of replaced elements and more investigation is necessary to understand what specified or unspecified behavior we are failing to implement. Signed-off-by: Martin Robinson <[email protected]>
servo-highfive
added
the
S-awaiting-review
TimvdLippe
approved these changes
Jan 28, 2026
servo-highfive
removed
the
S-awaiting-review
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The legacy alignment presentation hints differed from the specification
in a way that was breaking them when dealing with
<img>. The culpritseems to be the selector
img[type = image i]which seems a littlenonsensical. This change makes the CSS in
presentational-hints.cssmatch what is found in the specification.
There is still an issue with "bottom" alignment of replaced elements and
more investigation is necessary to understand what specified or
unspecified behavior we are failing to implement.
Testing: This fixes a variety of WPT tests.
Fixes: #41048.