script: Do not track outdated oustanding loads for stylesheets.#42208
Merged
TimvdLippe merged 1 commit intoservo:mainfrom Jan 28, 2026
Merged
script: Do not track outdated oustanding loads for stylesheets.#42208TimvdLippe merged 1 commit intoservo:mainfrom
TimvdLippe merged 1 commit intoservo:mainfrom
Conversation
Signed-off-by: Josh Matthews <[email protected]>
servo-highfive
added
the
S-awaiting-review
Member
Author
TimvdLippe
approved these changes
Jan 28, 2026
Contributor
TimvdLippe
left a comment
TimvdLippe
left a comment
There was a problem hiding this comment.
Nice fix and thanks for debugging!
servo-highfive
removed
the
S-awaiting-review
servo-highfive
added
the
S-awaiting-merge
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 28, 2026
The `HTMLLinkElement::pending_loads` field should only be used to track outstanding loads for the current generation; any loads from previous generations can be ignored. This avoids confusion about when to dispatch load/error events. See #42187 (comment) for more details about how the timing of multiple loads for the same `<link>` element resulted in intermittent timeouts in one WPT test. Testing: Intermittent failure did not appear within 75 runs; previously reproduced within 15. Fixes: #42187 Signed-off-by: Josh Matthews <[email protected]>
servo-highfive
removed
the
S-awaiting-merge
TimvdLippe
added a commit
to TimvdLippe/servo
that referenced
this pull request
Feb 9, 2026
Most likely a regression introduced in servo#42208 where the pending loads counter has been reset. For successful request this wasn't an issue, but for failed requests it was. Therefore, guard against these generation request problems by bailing out as soon as we post-process the request (which we do for all failed requests). Fixes servo#42477 Signed-off-by: Tim van der Lippe <[email protected]>
This was referenced Feb 9, 2026
TimvdLippe
added a commit
to TimvdLippe/servo
that referenced
this pull request
Feb 9, 2026
Most likely a regression introduced in servo#42208 where the pending loads counter has been reset. For successful request this wasn't an issue, but for failed requests it was. Therefore, guard against these generation request problems by bailing out as soon as we post-process the request (which we do for all failed requests). Fixes servo#42477 Signed-off-by: Tim van der Lippe <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 10, 2026
…ion (#42481) Most likely a regression introduced in #42208 where the pending loads counter has been reset. For successful request this wasn't an issue, but for failed requests it was. Therefore, guard against these generation request problems by bailing out as soon as we post-process the request (which we do for all failed requests). Fixes #42477 Signed-off-by: Tim van der Lippe <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
HTMLLinkElement::pending_loadsfield should only be used to track outstanding loads for the current generation; any loads from previous generations can be ignored. This avoids confusion about when to dispatch load/error events. See #42187 (comment) for more details about how the timing of multiple loads for the same<link>element resulted in intermittent timeouts in one WPT test.Testing: Intermittent failure did not appear within 75 runs; previously reproduced within 15.
Fixes: #42187