script: Match :modal when dialog is modal#42201
Conversation
|
🔨 Triggering try run (#21421032213) for Linux (WPT) |
|
Test results for linux-wpt from try job (#21421032213): Flaky unexpected result (36)
Stable unexpected results that are known to be intermittent (22)
Stable unexpected results (5)
|
|
|
:modal when dialog is modal:modal when dialog is modal
Servo PR: servo/servo#42201 Signed-off-by: Luke Warlow <[email protected]>
87aef15 to
607ac26
Compare
607ac26 to
86f6039
Compare
|
🔨 Triggering try run (#21490606743) for Linux (WPT) |
86f6039 to
88fb961
Compare
|
Test results for linux-wpt from try job (#21490606743): Flaky unexpected result (32)
Stable unexpected results that are known to be intermittent (32)
Stable unexpected results (5)
|
|
|
88fb961 to
18167ab
Compare
|
🔨 Triggering try run (#21586214049) for Linux (WPT) |
|
Test results for linux-wpt from try job (#21586214049): Flaky unexpected result (33)
Stable unexpected results that are known to be intermittent (30)
Stable unexpected results (1)
|
|
|
18167ab to
ce30470
Compare
|
🔨 Triggering try run (#21587615769) for Linux (WPT) |
|
Test results for linux-wpt from try job (#21587615769): Flaky unexpected result (39)
Stable unexpected results that are known to be intermittent (33)
|
|
✨ Try run (#21587615769) succeeded. |
Servo PR: servo/servo#42201 Signed-off-by: Luke Warlow <[email protected]>
|
@lukewarlow I've sent the Stylo PR to the MQ. Please update the Stylo hashes when that lands. Thanks! |
Also clean-up the UA stylesheet for dialogs. Signed-off-by: Luke Warlow <[email protected]>
ce30470 to
591916d
Compare
|
🔨 Triggering try run (#21639981216) for Linux (WPT) |
|
Updated this patch with the new hash. Just running WPT bot to double check it all. |
|
Test results for linux-wpt from try job (#21639981216): Flaky unexpected result (38)
Stable unexpected results that are known to be intermittent (28)
|
|
✨ Try run (#21639981216) succeeded. |
Loirooriol
left a comment
There was a problem hiding this comment.
I will land this anyways since the Stylo PR landed. If is_modal can be removed, please do a follow-up
| @@ -129,6 +129,7 @@ impl HTMLDialogElement { | |||
|
|
|||
| // Step 13. Set is modal of subject to true. | |||
| self.is_modal.set(true); | |||
There was a problem hiding this comment.
Is is_modal still needed? Seems we could just check the element state instead.
There was a problem hiding this comment.
Yeah I will do a follow-up to clean that up a bit. Like you say it's probably not needed anymore.
Servo PR: servo/servo#42201 Signed-off-by: Luke Warlow <[email protected]>
Servo PR: servo/servo#42201 Signed-off-by: Luke Warlow <[email protected]>
Servo PR: servo/servo#42201 Signed-off-by: Luke Warlow <[email protected]>
Servo PR: servo/servo#42201 Signed-off-by: Luke Warlow <[email protected]>
In addition, clean-up the UA stylesheet for dialogs.
Stylo PR: servo/stylo#301
Testing: change causes several WPT tests to start passing.