script: Add support for :open pseudo-class#42195
Conversation
|
🔨 Triggering try run (#21411098388) for Linux (WPT) |
|
Test results for linux-wpt from try job (#21411098388): Flaky unexpected result (30)
Stable unexpected results that are known to be intermittent (34)
Stable unexpected results (6)
|
|
|
16aede4 to
244b5e7
Compare
|
🔨 Triggering try run (#21412805153) for Linux (WPT) |
|
Test results for linux-wpt from try job (#21412805153): Flaky unexpected result (29)
Stable unexpected results that are known to be intermittent (29)
|
|
✨ Try run (#21412805153) succeeded. |
| @@ -1,3 +1,4 @@ | |||
| [select-type-to-search.tentative.html] | |||
| expected: ERROR | |||
There was a problem hiding this comment.
What causes these tests to ERROR. It would be worth mentioning this in the "Testing" field.
There was a problem hiding this comment.
Ah good point, fwiw it's an expected change the test just makes it further through now we support :open and so it hits test_driver.
mrobinson
left a comment
There was a problem hiding this comment.
Looks good, but please update the Cargo.toml file with the real Stylo revision hash before landing.
Yeah will do once the stylo PR is merged :) the merge conflict will keep it in my mind. |
Servo PR: servo/servo#42195 Signed-off-by: Luke Warlow <[email protected]>
Apologies, that should land shortly. |
244b5e7 to
493c22b
Compare
493c22b to
2e35472
Compare
:open pseudo-class:open pseudo-class
|
Hmm there seems to be a consistent failure in that test same as the other branch. |
|
It could be that the test needs to be marked at intermittent. |
This is supported on dialog, details and select elements. Signed-off-by: Luke Warlow <[email protected]>
Signed-off-by: Luke Warlow <[email protected]>
2e35472 to
337eb04
Compare
|
🔨 Triggering try run (#21486389802) for Linux (WPT) |
|
Test results for linux-wpt from try job (#21486389802): Flaky unexpected result (29)
Stable unexpected results that are known to be intermittent (23)
|
|
✨ Try run (#21486389802) succeeded. |
Servo PR: servo/servo#42195 Signed-off-by: Luke Warlow <[email protected]>
Servo PR: servo/servo#42195 Signed-off-by: Luke Warlow <[email protected]>
Add support for
:openpseudo-class. This is supported on dialog, details and select elements.Stylo PR: servo/stylo#297
Testing: WPTs but also
data:text/html,<select><option>123</option></select><style>:open { background-color: red; }</style>. There are some tests that now error, these previously failed due to missing:openand now make it further along hitting test_driver.send_keys() which causes them to errorFixes: #41277.