webdriver: Wait indefinitely with None timeout#42184
Conversation
|
🔨 Triggering try run (#21395045641) for Linux (WPT) |
|
Test results for linux-wpt from try job (#21395045641): Flaky unexpected result (30)
Stable unexpected results that are known to be intermittent (31)
Stable unexpected results (1)
|
|
|
|
🔨 Triggering try run (#21397359156) for Linux (WPT) |
|
Test results for linux-wpt from try job (#21397359156): Flaky unexpected result (34)
Stable unexpected results that are known to be intermittent (28)
|
|
✨ Try run (#21397359156) succeeded. |
|
I'll add a test to this before merging.. |
Signed-off-by: Euclid Ye <[email protected]>
Signed-off-by: Euclid Ye <[email protected]>
30fb868 to
9fc9029
Compare
|
🤖 Opened new upstream WPT pull request (web-platform-tests/wpt#57403) with upstreamable changes. |
Signed-off-by: Euclid Ye <[email protected]>
|
✍ Updated existing upstream WPT pull request (web-platform-tests/wpt#57403) title and body. |
6e3270c to
9fa8c4c
Compare
|
📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#57403). |
|
Waiting for upstream review for tests. |
So far for `None` [timeout](https://w3c.github.io/webdriver/#dfn-timeouts-configuration), we've treated it effectively as no wait which is wrong: web-platform-tests/wpt#57332 (comment). This PR makes all `None` timeouts wait indefinitely. The funny part is, we somehow have only done it correctly for `pageload`: https://w3c.github.io/webdriver/#dfn-timeouts-configuration Testing: We add test for script execution with `None` script timeout. --------- Signed-off-by: Euclid Ye <[email protected]>
…-wpt)
{"fail_fast": false, "matrix": [{"name": "Linux (WPT)", "workflow": "linux", "wpt": true, "profile": "release", "unit_tests": false, "build_libservo": false, "bencher": false, "coverage": false, "build_args": "", "wpt_args": "", "number_of_wpt_chunks": 20}]}
So far for
Nonetimeout, we've treated it effectively as no wait which is wrong: web-platform-tests/wpt#57332 (comment).This PR makes all
Nonetimeouts wait indefinitely. The funny part is, we somehow have only done it correctly forpageload: https://w3c.github.io/webdriver/#dfn-timeouts-configurationTesting: We add test for script execution with
Nonescript timeout.