Skip to content

wdspec tests: Null "implicit wait" should not have timer#42158

Closed
yezhizhen wants to merge 2 commits intoservo:mainfrom
yezhizhen:fix-test
Closed

wdspec tests: Null "implicit wait" should not have timer#42158
yezhizhen wants to merge 2 commits intoservo:mainfrom
yezhizhen:fix-test

Conversation

@yezhizhen
Copy link
Copy Markdown
Member

@yezhizhen yezhizhen commented Jan 26, 2026

@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Jan 26, 2026
@servo-wpt-sync servo-wpt-sync mentioned this pull request Jan 26, 2026
Closed
@servo-wpt-sync
Copy link
Copy Markdown
Collaborator

servo-wpt-sync commented Jan 26, 2026

🤖 Opened new upstream WPT pull request (web-platform-tests/wpt#57332) with upstreamable changes.

TimvdLippe
TimvdLippe reviewed Jan 26, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@TimvdLippe TimvdLippe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since these are only changes to WPT, please make the PR in the WPT repository instead. If Servo-related changes need to be made, then we can keep it here.

@yezhizhen
Copy link
Copy Markdown
Member Author

yezhizhen commented Jan 26, 2026

Since these are only changes to WPT, please make the PR in the WPT repository instead. If Servo-related changes need to be made, then we can keep it here.

I asked this question with @jdm in the past actually. He says we can do it in this way.

@yezhizhen yezhizhen added the T-webdriver Do a try run of the WebDriver conformance tests label Jan 26, 2026
@github-actions github-actions bot removed the T-webdriver Do a try run of the WebDriver conformance tests label Jan 26, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 26, 2026

🔨 Triggering try run (#21355099230) for Linux (WPT)

@yezhizhen
Copy link
Copy Markdown
Member Author

yezhizhen commented Jan 26, 2026 •
edited
Loading

Since these are only changes to WPT, please make the PR in the WPT repository instead. If Servo-related changes need to be made, then we can keep it here.

But on second thought you are right. There is no point doing it in this way.

The test expectation won't change, until the next webdriver crate version released: https://bugzilla.mozilla.org/show_bug.cgi?id=1938333#c3

@yezhizhen
Copy link
Copy Markdown
Member Author

yezhizhen commented Jan 26, 2026 •
edited
Loading

But on second thought you are right. There is no point doing it in this way.

But on third thought: I do this because I don't wanna clone web-platform-tests. I think Firefox team also do this sometimes? (I don't know about Chrome team)

@yezhizhen
Copy link
Copy Markdown
Member Author

yezhizhen commented Jan 26, 2026

I think Firefox team also do this sometimes? (I don't know about Chrome team)

For example this one: https://phabricator.services.mozilla.com/D223646

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 26, 2026

Test results for linux-wpt from try job (#21355099230):

Flaky unexpected result (1)
  • OK /webdriver/tests/classic/perform_actions/wheel.py
    • ERROR [expected PASS] subtest: test_null_response_value

      teardown error:

    • ERROR [expected PASS] subtest: test_no_top_browsing_context

      setup error: ConnectionRefusedError: [Errno 111] Connection refused

    • ERROR [expected PASS] subtest: test_no_browsing_context

      setup error: ConnectionRefusedError: [Errno 111] Connection refused

    • ERROR [expected PASS] subtest: test_params_actions_origin_outside_viewport[element]

      setup error: ConnectionRefusedError: [Errno 111] Connection refused

    • ERROR [expected PASS] subtest: test_params_actions_origin_outside_viewport[viewport]

      setup error: ConnectionRefusedError: [Errno 111] Connection refused

    • ERROR [expected PASS] subtest: test_scroll_not_scrollable

      setup error: ConnectionRefusedError: [Errno 111] Connection refused

    • ERROR [expected PASS] subtest: test_scroll_scrollable_overflow

      setup error: ConnectionRefusedError: [Errno 111] Connection refused

    • ERROR [expected PASS] subtest: test_scroll_iframe

      setup error: ConnectionRefusedError: [Errno 111] Connection refused

    • ERROR [expected PASS] subtest: test_scroll_shadow_tree[outer-open]

      setup error: ConnectionRefusedError: [Errno 111] Connection refused

    • ERROR [expected PASS] subtest: test_scroll_shadow_tree[outer-closed]

      setup error: ConnectionRefusedError: [Errno 111] Connection refused

    • And 3 more unexpected results...
Stable unexpected results (6)
  • OK /webdriver/tests/classic/find_element/find.py
    • FAIL [expected PASS] subtest: test_implicit_wait_none

      webdriver.error.InvalidArgumentException: invalid argument (400): null is not a positive integer at line 1 column 18

  • OK /webdriver/tests/classic/find_element_from_element/find.py
    • FAIL [expected PASS] subtest: test_implicit_wait_none

      webdriver.error.InvalidArgumentException: invalid argument (400): null is not a positive integer at line 1 column 18

  • OK /webdriver/tests/classic/find_element_from_shadow_root/find.py
    • FAIL [expected PASS] subtest: test_implicit_wait_none_shadow_root

      webdriver.error.InvalidArgumentException: invalid argument (400): null is not a positive integer at line 1 column 18

  • OK /webdriver/tests/classic/find_elements/find.py
    • FAIL [expected PASS] subtest: test_implicit_wait_none

      webdriver.error.InvalidArgumentException: invalid argument (400): null is not a positive integer at line 1 column 18

  • OK /webdriver/tests/classic/find_elements_from_element/find.py
    • FAIL [expected PASS] subtest: test_implicit_wait_none

      webdriver.error.InvalidArgumentException: invalid argument (400): null is not a positive integer at line 1 column 18

  • OK /webdriver/tests/classic/find_elements_from_shadow_root/find.py
    • FAIL [expected PASS] subtest: test_implicit_wait_none_shadow_root

      webdriver.error.InvalidArgumentException: invalid argument (400): null is not a positive integer at line 1 column 18

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 26, 2026

⚠️ Try run (#21355099230) failed!

@yezhizhen
Copy link
Copy Markdown
Member Author

yezhizhen commented Jan 26, 2026 •
edited
Loading

The test expectation won't change

The failing tests are renamed, so in that sense it does change..

@yezhizhen
Copy link
Copy Markdown
Member Author

yezhizhen commented Jan 26, 2026 •
edited
Loading

@TimvdLippe There is another reason: ./mach update-wpt won't remove those renamed/removed entry in .ini. So have to do it manually.
(Sorry for the spam. But my thoughts keep changing today.)

@yezhizhen yezhizhen mentioned this pull request Jan 26, 2026
Open
@servo-wpt-sync
Copy link
Copy Markdown
Collaborator

servo-wpt-sync commented Jan 26, 2026

📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#57332).

TimvdLippe
TimvdLippe approved these changes Jan 26, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@TimvdLippe TimvdLippe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving given that it also updates our test expectations. Please conduct the code review upstream like you did with previous test changes.

@servo-highfive servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Jan 26, 2026
@yezhizhen
Copy link
Copy Markdown
Member Author

yezhizhen commented Jan 27, 2026

Closing due to: web-platform-tests/wpt#57332 (comment)

@yezhizhen yezhizhen closed this Jan 27, 2026
@yezhizhen yezhizhen deleted the fix-test branch January 27, 2026 11:35
@yezhizhen yezhizhen mentioned this pull request Feb 6, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TimvdLippe TimvdLippe TimvdLippe approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yezhizhen @servo-wpt-sync @TimvdLippe @servo-highfive