css: Enable registered custom properties with CSSOM but stay unanimatable#42136
Merged
yezhizhen merged 6 commits intoservo:mainfrom Jan 31, 2026
Merged
css: Enable registered custom properties with CSSOM but stay unanimatable#42136yezhizhen merged 6 commits intoservo:mainfrom
yezhizhen merged 6 commits intoservo:mainfrom
Conversation
|
🔨 Triggering try run (#21329329850) for Linux (WPT) |
|
Test results for linux-wpt from try job (#21329329850): Flaky unexpected result (41)
Stable unexpected results that are known to be intermittent (27)
|
|
✨ Try run (#21329329850) succeeded. |
nicoburns
approved these changes
Jan 25, 2026
Loirooriol
requested changes
Jan 28, 2026
Contributor
Loirooriol
left a comment
There was a problem hiding this comment.
First please create another PR to stop skipping tests:
Lines 87 to 88 in 3b60a07
Then in this PR we will see how many tests improve.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 28, 2026
This will allow us to see the test improvements from #42136. Testing: Existing WPT --------- Signed-off-by: Euclid Ye <[email protected]>
8a22cd3 to
5922206
Compare
5922206 to
0ba2569
Compare
|
🔨 Triggering try run (#21464780680) for Linux (WPT) |
|
Test results for linux-wpt from try job (#21464780680): Flaky unexpected result (38)
Stable unexpected results that are known to be intermittent (31)
|
cfa3c6a to
c489012
Compare
|
🔨 Triggering try run (#21544529885) for Linux (WPT) |
Signed-off-by: Euclid Ye <[email protected]>
|
Test results for linux-wpt from try job (#21544529885): Flaky unexpected result (31)
Stable unexpected results that are known to be intermittent (26)
|
|
✨ Try run (#21544529885) succeeded. |
|
🔨 Triggering try run (#21544890366) for Linux (WPT) |
|
Test results for linux-wpt from try job (#21544890366): Flaky unexpected result (32)
Stable unexpected results that are known to be intermittent (27)
Stable unexpected results (1)
|
|
|
Signed-off-by: Euclid Ye <[email protected]>
Loirooriol
approved these changes
Jan 31, 2026
github-merge-queue bot
pushed a commit
to servo/stylo
that referenced
this pull request
Jan 31, 2026
This will add support for `@property` rules. Servo Companion: servo/servo#42136 Note that registered properties don't animate correctly: #38 Signed-off-by: Euclid Ye <[email protected]>
Signed-off-by: Euclid Ye <[email protected]>
Signed-off-by: Euclid Ye <[email protected]>
Loirooriol
pushed a commit
to servo/stylo
that referenced
this pull request
Feb 5, 2026
This will add support for `@property` rules. Servo Companion: servo/servo#42136 Note that registered properties don't animate correctly: #38 Signed-off-by: Euclid Ye <[email protected]>
Loirooriol
pushed a commit
to servo/stylo
that referenced
this pull request
Feb 5, 2026
This will add support for `@property` rules. Servo Companion: servo/servo#42136 Note that registered properties don't animate correctly: #38 Signed-off-by: Euclid Ye <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many websites use Tailwind CSS script which utilizes registered custom properties.
This PR makes such websites look as expected, such as #42129.
Before:

After:

Testing: Updated existing WPT results.
Fixes: #42129
Fixes: #41417
Stylo Companion: servo/stylo#293