Conversation
852a2ec to
9883d1d
Compare
7bae835 to
4cecb1b
Compare
We have a implementation of PaintTiming , so we should run the tests associated with them. Testing: New tests enabled. Signed-off-by: Shubham Gupta <[email protected]>
4cecb1b to
224c4a5
Compare
|
I guess few tests seem to flaky. Can you guide how to test/mark flaky... Also is there any dashboard for flaky/Intermittent? |
|
If these tests are flaky can we fix or at least triage the issue causing the flakiness before enabling them? Enabling flaky tests has negative affects on everyone else because it clogs up the CI infrastructure. If an entire directory is flaky, more sources of flakiness appear when tests are added, even if you've previously marked all preexisting tests as flaky. You could mark the entire directory as flaky, but then the tests results don't really matter as the CI will accept either an expected or unexpected result. On the other hand, if you spend the time to understand what is causing the flakiness, there's a path toward fixing it, ensuring that tests do not flake and that the feature is implemented correctly. This is one of the key parts of implementing a feature on the web platform and eliminating sources of flakiness in the code should be a priority for the web engine. |
Yeah, I agree on your point. Source of flakiness should be eliminated.
Is there any dashboard which tracks this flakiness over last runs and flag that now this test is stable? |
224c4a5 to
5476724
Compare
|
🔨 Triggering try run (#21717418181) for Linux (WPT) |
|
Test results for linux-wpt from try job (#21717418181): Flaky unexpected result (39)
Stable unexpected results that are known to be intermittent (43)
|
|
✨ Try run (#21717418181) succeeded. |
|
🔨 Triggering try run (#21735213608) for Linux (WPT) |
|
Test results for linux-wpt from try job (#21735213608): Flaky unexpected result (31)
Stable unexpected results that are known to be intermittent (32)
|
|
✨ Try run (#21735213608) succeeded. |
|
🔨 Triggering try run (#21735999707) for Linux (WPT) |
|
Test results for linux-wpt from try job (#21735999707): Flaky unexpected result (31)
Stable unexpected results that are known to be intermittent (30)
|
|
✨ Try run (#21735999707) succeeded. |
|
🔨 Triggering try run (#21736655229) for Linux (WPT) |
|
Test results for linux-wpt from try job (#21736655229): Flaky unexpected result (35)
Stable unexpected results that are known to be intermittent (38)
|
|
✨ Try run (#21736655229) succeeded. |
We have a implementation of PaintTiming , so we should run the tests associated with them.
Testing: New tests enabled.