Skip to content

script: move stream-related files into script/dom/stream#42010

Merged
Taym95 merged 7 commits intoservo:mainfrom
hyuraku:move-stream
Jan 25, 2026
Merged

script: move stream-related files into script/dom/stream#42010
Taym95 merged 7 commits intoservo:mainfrom
hyuraku:move-stream

Conversation

@hyuraku
Copy link
Copy Markdown
Contributor

@hyuraku hyuraku commented Jan 19, 2026

Describe the changes that this pull request makes here. This will be the commit message.
Move stream file to script/dom/stream
part of #38901

Testing: Describe how this pull request is tested or why it doesn't require tests
Fixes: Link to an issue this pull requests fixes or remove this line if there is no issue

@hyuraku hyuraku requested a review from gterzian as a code owner January 19, 2026 13:49
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Jan 19, 2026
Taym95
Taym95 requested changes Jan 19, 2026
View reviewed changes
components/script/dom/mod.rs Outdated
Comment on lines 266 to 267
pub(crate) mod defaultteereadrequest;
pub(crate) mod defaultteeunderlyingsource;
Copy link
Copy Markdown
Member

@Taym95 Taym95 Jan 19, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

defaultteereadrequest and defaultteeunderlyingsource are also stream related code

components/script/dom/mod.rs Outdated
Copy link
Copy Markdown
Member

@Taym95 Taym95 Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one is also stream realted

components/script/dom/mod.rs Outdated
Comment on lines 232 to 234
Copy link
Copy Markdown
Member

@Taym95 Taym95 Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

byteteereadintorequest, byteteereadrequest, byteteeunderlyingsource stream related

components/script/dom/mod.rs Outdated
pub(crate) mod compressionstream;
pub(crate) mod console;
pub(crate) mod cookiestore;
pub(crate) mod countqueuingstrategy;
Copy link
Copy Markdown
Member

@Taym95 Taym95 Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

countqueuingstrategy stream related

components/script/dom/mod.rs
pub(crate) mod textcontrol;
pub(crate) mod textdecoder;
pub(crate) mod textdecodercommon;
pub(crate) mod textdecoderstream;
Copy link
Copy Markdown
Member

@Taym95 Taym95 Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

humm I am not sure this is stream, this an API that uses stream, stream code is one that implements stream spec https://streams.spec.whatwg.org not the one that uses it.

components/script/dom/mod.rs Outdated
Copy link
Copy Markdown
Member

@Taym95 Taym95 Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this also stream

@servo-highfive servo-highfive added S-needs-code-changes Changes have not yet been made that were requested by a reviewer. S-awaiting-review There is new code that needs to be reviewed. and removed S-awaiting-review There is new code that needs to be reviewed. S-needs-code-changes Changes have not yet been made that were requested by a reviewer. labels Jan 19, 2026
Taym95
Taym95 approved these changes Jan 19, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@Taym95 Taym95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution.

@servo-highfive servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Jan 19, 2026
@Taym95 Taym95 enabled auto-merge January 19, 2026 22:35
@Taym95
Copy link
Copy Markdown
Member

Taym95 commented Jan 19, 2026

@hyuraku can you build locally and check clippy?

@hyuraku
Copy link
Copy Markdown
Contributor Author

hyuraku commented Jan 20, 2026

@hyuraku can you build locally and check clippy?

@Taym95
./mach build currently fails on my macOS 26.2 environment
(Darwin kernel 25.2.0) due to compatibility issues with two
dependency crates:

  • harfbuzz-sys v0.6.1
  • aws-lc-sys v0.36.0

@mrobinson
Copy link
Copy Markdown
Member

mrobinson commented Jan 20, 2026

@Taym95 ./mach build currently fails on my macOS 26.2 environment (Darwin kernel 25.2.0) due to compatibility issues with two dependency crates:

* `harfbuzz-sys v0.6.1`
* `aws-lc-sys v0.36.0`

It's very important that we fix this sooner rather than later. Do you mind opening an issue with the build failures?

@hyuraku
Copy link
Copy Markdown
Contributor Author

hyuraku commented Jan 20, 2026

@Taym95 ./mach build currently fails on my macOS 26.2 environment (Darwin kernel 25.2.0) due to compatibility issues with two dependency crates:

* `harfbuzz-sys v0.6.1`
* `aws-lc-sys v0.36.0`

It's very important that we fix this sooner rather than later. Do you mind opening an issue with the build failures?

@Taym95
I opened #42030

auto-merge was automatically disabled January 20, 2026 15:01

Head branch was pushed to by a user without write access

@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Jan 20, 2026
@TimvdLippe TimvdLippe enabled auto-merge January 21, 2026 07:41
auto-merge was automatically disabled January 21, 2026 14:38

Head branch was pushed to by a user without write access

@hyuraku hyuraku requested a review from atbrakhi as a code owner January 21, 2026 14:38
@servo-highfive servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Jan 25, 2026
@Taym95 Taym95 enabled auto-merge January 25, 2026 12:47
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Jan 25, 2026
@Taym95 Taym95 added this pull request to the merge queue Jan 25, 2026
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Jan 25, 2026
@Taym95 Taym95 mentioned this pull request Jan 25, 2026
Open
27 tasks
@Taym95
Fix Build
b3a28d4 
Signed-off-by: Taym Haddadi <[email protected]>
@servo-highfive servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Jan 25, 2026
Merged via the queue into servo:main with commit a973178 Jan 25, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Taym95 Taym95 Taym95 approved these changes

@gterzian gterzian Awaiting requested review from gterzian gterzian is a code owner

@atbrakhi atbrakhi Awaiting requested review from atbrakhi

Assignees

No one assigned

Labels

S-awaiting-review There is new code that needs to be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hyuraku @Taym95 @mrobinson @servo-highfive