script: Fix render blocking stylesheet load fire ordering#41973
script: Fix render blocking stylesheet load fire ordering#41973jdm merged 1 commit intoservo:mainfrom
Conversation
|
🔨 Triggering try run (#21091419278) for Linux (WPT) |
|
Test results for linux-wpt from try job (#21091419278): Flaky unexpected result (41)
Stable unexpected results that are known to be intermittent (41)
Stable unexpected results (108)
|
|
|
mrobinson
left a comment
There was a problem hiding this comment.
Looks great. Just a few questions:
|
I'm not surprised tests are failing as the order of things is very sensitive here. I think this is heading in the right direction though! |
|
Thanks for the review! I thought that it worked, at least locally it did. But then WPT came back a lot more red than I expected. I am landing some other cleanup fixes first, so that I can narrow down the core issue here. Marking it as draft for now until things stabilize. |
8421ab8 to
4499e1a
Compare
|
🔨 Triggering try run (#21178214061) for Linux (WPT) |
|
Test results for linux-wpt from try job (#21178214061): Flaky unexpected result (39)
Stable unexpected results that are known to be intermittent (31)
Stable unexpected results (67)
|
|
|
4499e1a to
7f7e322
Compare
|
🔨 Triggering try run (#21282564517) for Linux (WPT) |
|
🤖 Opened new upstream WPT pull request (web-platform-tests/wpt#57306) with upstreamable changes. |
7f7e322 to
a53b491
Compare
|
📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#57306). |
|
Test results for linux-wpt from try job (#21282564517): Flaky unexpected result (29)
Stable unexpected results that are known to be intermittent (36)
Stable unexpected results (5)
|
|
|
a53b491 to
06d7048
Compare
|
🔨 Triggering try run (#21298115921) for Linux (WPT) |
|
📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#57306). |
|
Test results for linux-wpt from try job (#21298115921): Flaky unexpected result (34)
Stable unexpected results that are known to be intermittent (32)
|
|
✨ Try run (#21298115921) succeeded. |
|
Built on top of the other two PRs. Lint error I will fix when rebasing |
06d7048 to
eefb83f
Compare
While adding various spec comments to the parts of #the-end (which are scattered throughout the script crate), I stumbled upon the render blocking stylesheets implementation. There was a HTML PR to make clear when it should run and the corresponding WPT tests have been fixed. Signed-off-by: Tim van der Lippe <[email protected]>
|
🤖 This change no longer contains upstreamable changes to WPT; closed existing upstream pull request (web-platform-tests/wpt#57306). |
While adding various spec comments to the parts of
#the-end(which are scattered throughout the script crate), I stumbled upon the render blocking stylesheets implementation. There was a HTML PR to make clear when it should run and the corresponding WPT tests have been fixed.Fixes #22715