script: Fix loading of about:srcdoc documents#41959
Conversation
5613ac5 to
6149e69
Compare
|
🔨 Triggering try run (#21778154557) for Linux (WPT) |
|
Test results for linux-wpt from try job (#21778154557): Flaky unexpected result (29)
Stable unexpected results that are known to be intermittent (39)
Stable unexpected results (1)
|
|
|
6149e69 to
4860f0a
Compare
| @@ -0,0 +1,68 @@ | |||
| <!DOCTYPE html> | |||
| <head> | |||
| <title>Below-viewport srcdoc iframes with loading='lazy' load when set to | |||
There was a problem hiding this comment.
Verified this test passes now in Servo and Gecko. In Chromium it fails, but Chromium also fails the related test: https://wpt.fyi/results/html/semantics/embedded-content/the-iframe-element/iframe-loading-lazy.html?label=experimental&label=master&aligned
Note that this test is almost equivalent to tests/wpt/tests/html/semantics/embedded-content/the-iframe-element/iframe-loading-lazy-to-eager.html, but uses srcdoc instead of src. That's the test coverage which was missing, which is why WPT didn't report any changes before.
| // attribute boolean seamless; | ||
| [CEReactions] | ||
| attribute boolean allowFullscreen; | ||
| [CEReactions] attribute USVString src; |
There was a problem hiding this comment.
Figured to literally copy the webidl definition from the spec, since things were moved around and seamless (the previous name of loading afaik) no longer exists.
|
🤖 Opened new upstream WPT pull request (web-platform-tests/wpt#57638) with upstreamable changes. |
4860f0a to
17870c6
Compare
|
📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#57638). |
17870c6 to
8b53b01
Compare
|
📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#57638). |
Align with the spec and implement part of its lazy loading steps. Most tests use non-srcdoc lazy loading URLs, so most tests will not pass until the other parts are implemented as well. Signed-off-by: Tim van der Lippe <[email protected]>
8b53b01 to
2385706
Compare
|
📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#57638). |
Align with the spec and implement part of its lazy loading steps. Most tests use non-srcdoc lazy loading URLs, so most tests will not pass until the other parts are implemented as well. Signed-off-by: Tim van der Lippe <[email protected]>
Align with the spec and implement part of its lazy loading
steps. Most tests use non-srcdoc lazy loading URLs, so most
tests will not pass until the other parts are implemented
as well.