Merged
Conversation
Narfinger
force-pushed
the
mitmproxy-test
branch
2 times, most recently
from
2935e5b to
9a0e9b2
Compare
Narfinger
force-pushed
the
mitmproxy-test
branch
5 times, most recently
from
132eb79 to
190d1b4
Compare
Narfinger
force-pushed
the
mitmproxy-test
branch
from
d7e4008 to
43be771
Compare
Contributor
Author
|
@jschwe Updated it. |
jschwe
reviewed
Jan 22, 2026
jschwe
reviewed
Jan 22, 2026
jschwe
reviewed
Jan 22, 2026
jschwe
reviewed
Jan 22, 2026
jschwe
reviewed
Jan 22, 2026
Narfinger
force-pushed
the
mitmproxy-test
branch
from
12d90b7 to
e131c93
Compare
This comment was marked as resolved.
This comment was marked as resolved.
servo-highfive
added
the
S-awaiting-review
yezhizhen
requested changes
Jan 23, 2026
Member
There was a problem hiding this comment.
For all action run links you provided, I did not see any output like before in scenario tests, and all finish in 1 sec:
Here is a sample before your PR:
https://github.com/servo/servo/actions/runs/21271461325/job/61222532498
servo-highfive
added
S-needs-code-changes
Narfinger
force-pushed
the
mitmproxy-test
branch
from
e131c93 to
dc035b2
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Narfinger
force-pushed
the
mitmproxy-test
branch
from
dc035b2 to
f3a6318
Compare
servo-highfive
removed
the
S-needs-code-changes
Narfinger
force-pushed
the
mitmproxy-test
branch
from
5e9c080 to
cc11e85
Compare
servo-highfive
added
the
S-awaiting-review
Signed-off-by: Narfinger <[email protected]>
Signed-off-by: Narfinger <[email protected]>
Signed-off-by: Narfinger <[email protected]>
Contributor
Author
|
I would have assumed that too but I don't know why. |
servo-highfive
added
the
S-awaiting-merge
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 4, 2026
This has a couple of changes to use mitmproxy in the ohos benchmarking CI. - We include an easy script to create a mitmproxy dump (etc/ci/scenario/update-mitmproxy-dump.py). - We set the port forwarding in the common_function_for_servo_test (with a refactor of the code). - We added the use of mitmproxy to scenario test and bencher runs. This currently runs in strictly forwarding mode. But because we skip the wifi connection and use a wired connection, this should defeat jitter a bit. - This does _not_ include the smoketest and hitrace-bench. Signed-off-by: Narfinger <[email protected]> Testing: https://github.com/Narfinger/servo/actions/runs/21630846381/job/62343433828 In the future we will add smoketest and hitrace-bench to use mitmproxy and finally switch mitmproxy to record and replay mode. --------- Signed-off-by: Narfinger <[email protected]>
Member
How to use this? Can you write a guide? Also explain a bit how the dump works. Maybe also some URL to introduce mitmproxy too. Thanks! |
servo-highfive
removed
the
S-awaiting-merge
Contributor
Author
|
Do you have a good idea where to write this? There is already a guide on mitmproxy in the servo book. |
Member
Ah nice. Can you put in PR description at least? I think you are talking about https://book.servo.org/contributing/profiling.html?highlight=mitmproxy#webpage-snapshots Also, maybe write at the top of |
yezhizhen
reviewed
Feb 4, 2026
Signed-off-by: Narfinger <[email protected]>
Signed-off-by: Narfinger <[email protected]>
servo-highfive
removed
the
S-awaiting-review
Co-authored-by: Euclid Ye <[email protected]> Signed-off-by: Narfinger <[email protected]>
servo-highfive
added
the
S-awaiting-review
Member
|
@Narfinger |
Signed-off-by: Narfinger <[email protected]>
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has a couple of changes to use mitmproxy (see more https://book.servo.org/contributing/profiling.html?highlight=mitmproxy#webpage-snapshots) in the ohos benchmarking CI.
Signed-off-by: Narfinger [email protected]
Testing: https://github.com/Narfinger/servo/actions/runs/21630846381/job/62343433828
In the future we will add smoketest and hitrace-bench to use mitmproxy and finally switch mitmproxy to record and replay mode.