script: Include click count as the detail of mouseup and mousedown events#41833
Merged
mrobinson merged 1 commit intoservo:mainfrom Jan 12, 2026
Merged
script: Include click count as the detail of mouseup and mousedown events#41833mrobinson merged 1 commit intoservo:mainfrom
detail of mouseup and mousedown events#41833mrobinson merged 1 commit intoservo:mainfrom
Conversation
servo-highfive
added
the
S-awaiting-review
mrobinson
force-pushed
the
improve-click-counting
branch
from
2848ea3 to
55c75a9
Compare
TimvdLippe
approved these changes
Jan 11, 2026
Contributor
TimvdLippe
left a comment
TimvdLippe
left a comment
There was a problem hiding this comment.
Seems logical to follow, thanks for the great comments in the code that explain what's going on here.
servo-highfive
removed
the
S-awaiting-review
servo-highfive
added
the
S-awaiting-merge
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 12, 2026
…wn` events (#41833) This change improves the counting of clicks for mouse button events by ensuring that `detail` property of those events includes the click count. This `detail` differs from that of `dblclick` events where the `detail` is always 2. In addition, it ensures that the click count can increase for mouse buttons that do not cause `click` and `dblclick` events (such as the right mouse button). Testing: This change adds two Servo-specific WPT-style tests. While this behavior is specified a bit, the details are implementation specific. Signed-off-by: Martin Robinson <[email protected]>
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
servo-highfive
added
S-tests-failed
…wn` events This change improves the counting of clicks for mouse button events by ensuring that `detail` property of those events includes the click count. This `detail` differs from that of `dblclick` events where the `detail` is always 2. In addition, it ensure that the click count can increase for mouse buttons that do not cause `click` and `dblclick` events (such as the right mouse button). Signed-off-by: Martin Robinson <[email protected]>
mrobinson
force-pushed
the
improve-click-counting
branch
from
55c75a9 to
c40e3af
Compare
servo-highfive
added
S-awaiting-review
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change improves the counting of clicks for mouse button events by
ensuring that
detailproperty of those events includes the clickcount. This
detaildiffers from that ofdblclickevents where thedetailis always 2. In addition, it ensures that the click count canincrease for mouse buttons that do not cause
clickanddblclickevents (such as the right mouse button).
Testing: This change adds two Servo-specific WPT-style tests. While this
behavior is specified a bit, the details are implementation specific.