webdriver: Dispatch embedder `TouchEventType::Move` by yezhizhen · Pull Request #41801 · servo/servo

yezhizhen · 2026-01-09T12:41:00Z

Fixes: #41725
Fixes: #41620
Fixes: #39264
Fixes: #41250

Testing: Multiple new passing. Several tests that NOT RUN starts running.
Several new CRASH are actually

 0:25.43 INFO Browser not responding, setting status to CRASH
 0:25.43 TEST_END: CRASH, expected OK

, which is no regression because these tests were FAIL, ERROR or TIMEOUT.

yezhizhen

Check the obsolete PR #41793 (comment) which shows what happens if we block.

yezhizhen · 2026-01-09T12:42:22Z

components/webdriver_server/actions.rs

+                            ));
+                            // We should NOT block here. TouchMove is special, and may never
+                            // be forwarded to constellation and handled.
+                            self.send_input_event_to_embedder(input_event);


TouchMove is not guaranteed to be sent to constellation, and we really shouldn't block above, due to below:

servo/components/compositing/webview_renderer.rs

Lines 454 to 455 in f0233c3

let action = self.touch_handler.on_touch_move(event.id, point);

if let Some(action) = action {

github-actions · 2026-01-10T02:31:50Z

🔨 Triggering try run (#20871372562) for Linux (WPT)

github-actions · 2026-01-10T03:00:16Z

Test results for linux-wpt from try job (#20871372562):

Flaky unexpected result (24)

OK /IndexedDB/idbfactory-databases-opaque-origin.html
- FAIL [expected PASS] subtest: IDBFactory.databases() in non-sandboxed iframe should not reject
```
assert_equals: IDBFactory.databases() should not reject expected "no exception" but got "OperationError"
```
OK /IndexedDB/idbfactory-open-error-properties.any.html
- PASS [expected FAIL] subtest: Properties of error event from failed open()
OK /IndexedDB/idbfactory-open-error-properties.any.worker.html
- PASS [expected FAIL] subtest: Properties of error event from failed open()

OK /_mozilla/css/offset_properties_inline.html (#40543)

FAIL [expected PASS] subtest: offsetTop

assert_equals: offsetTop of #inline-1 should be 0. expected 0 but got -1

FAIL [expected PASS] subtest: offsetLeft

assert_equals: offsetLeft of #inline-2 should be 40. expected 40 but got 25

OK /_mozilla/webxr/create_session.https.html
- FAIL [expected PASS] subtest: create_session
```
can't access property "simulateDeviceConnection", navigator.xr.test is undefined
```
ERROR [expected TIMEOUT] /_mozilla/webxr/sessionavailable.https.html
OK /css/css-fonts/generic-family-keywords-003.html (#38994)
- PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted generic(nastaliq) (drawing text in a canvas)
- PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted ui-sans-serif (drawing text in a canvas)

OK /css/css-fonts/variations/font-weight-matching.html (#38577)

FAIL [expected PASS] subtest: Test @font-face matching for weight 99

assert_approx_equals: @font-face should be mapped to CSSTest Weights 900. expected 90 +/- 2 but got 180

FAIL [expected PASS] subtest: Test @font-face matching for weight 100

assert_approx_equals: @font-face should be mapped to CSSTest Weights 900. expected 90 +/- 2 but got 180

FAIL [expected PASS] subtest: Test @font-face matching for weight 249

assert_approx_equals: @font-face should be mapped to CSSTest Weights 900. expected 90 +/- 2 but got 180

FAIL [expected PASS] subtest: Test @font-face matching for weight 250

assert_approx_equals: @font-face should be mapped to CSSTest Weights 800. expected 90 +/- 2 but got 180

FAIL [expected PASS] subtest: Test @font-face matching for weight 399

assert_approx_equals: @font-face should be mapped to CSSTest Weights 800. expected 90 +/- 2 but got 180

FAIL [expected PASS] subtest: Test @font-face matching for weight 470

assert_approx_equals: @font-face should be mapped to CSSTest Weights 300. expected 90 +/- 2 but got 180

FAIL [expected PASS] subtest: Test @font-face matching for weight 500

assert_approx_equals: @font-face should be mapped to CSSTest Weights 300. expected 90 +/- 2 but got 180

OK /custom-elements/form-associated/ElementInternals-setFormValue.html (#29174)
- PASS [expected FAIL] subtest: Single value - empty name exists
- PASS [expected FAIL] subtest: Null value should submit nothing
- PASS [expected FAIL] subtest: Newline normalization - \r\n in filename (urlencoded)
- PASS [expected FAIL] subtest: Newline normalization - \r\n in FormData value (urlencoded)
TIMEOUT [expected OK] /fetch/api/redirect/redirect-keepalive.https.any.html (#32153)
- TIMEOUT [expected PASS] subtest: [keepalive][iframe][load] mixed content redirect; setting up
```
Test timed out
```
OK [expected ERROR] /fetch/fetch-later/quota/same-origin-iframe/sandboxed-iframe.https.window.html (#41704)
OK /html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/a-click.html (#28697)
- PASS [expected FAIL] subtest: aElement.click() before the load event must NOT replace
OK /html/browsers/history/the-history-interface/traverse_the_history_2.html (#21383)
- PASS [expected FAIL] subtest: Multiple history traversals, last would be aborted
TIMEOUT /html/semantics/embedded-content/media-elements/autoplay-disabled-by-feature-policy.https.sub.html (#41221)
- FAIL [expected TIMEOUT] subtest: Feature-Policy header: autoplay "none" disallows same-origin iframes.
```
assert_false: autoplay expected false got true
```
OK [expected TIMEOUT] /html/semantics/embedded-content/media-elements/src_object_blob.html (#40340)
- PASS [expected TIMEOUT] subtest: HTMLMediaElement.srcObject blob
TIMEOUT [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_navigate_other_frame_popup.sub.html (#39702)
- TIMEOUT [expected FAIL] subtest: Sandboxed iframe can not navigate other frame's popup
```
Test timed out
```
ERROR [expected TIMEOUT] /html/semantics/forms/form-submission-target/rel-base-target.html (#40379)
OK /preload/link-header-preload-delay-onload.html (#39622)
- FAIL [expected PASS] subtest: Makes sure that Link headers preload resources and block window.onload after resource discovery
```
assert_true: expected true got false
```
OK /resource-timing/buffer-full-add-then-clear.html (#40819)
- PASS [expected FAIL] subtest: Test that if the buffer is cleared after entries were added to the secondary buffer, those entries make it into the primary one
CRASH [expected OK] /trusted-types/block-string-assignment-to-DedicatedWorker-setTimeout-setInterval.html
OK [expected TIMEOUT] /trusted-types/trusted-types-navigation.html?06-10 (#37920)
- PASS [expected TIMEOUT] subtest: Navigate a frame via anchor with javascript:-urls w/ default policy in report-only mode.
- FAIL [expected NOTRUN] subtest: Navigate a window via anchor with javascript:-urls w/ a default policy throwing an exception in enforcing mode.
```
promise_test: Unhandled rejection with value: "Unexpected message received: \"No securitypolicyviolation reported!\""
```
- FAIL [expected NOTRUN] subtest: Navigate a window via anchor with javascript:-urls w/ a default policy throwing an exception in report-only mode.
```
promise_test: Unhandled rejection with value: "Unexpected message received: \"No securitypolicyviolation reported!\""
```
OK [expected TIMEOUT] /trusted-types/trusted-types-navigation.html?26-30 (#38807)
- PASS [expected TIMEOUT] subtest: Navigate a window via form-submission with javascript:-urls in report-only mode.
- PASS [expected NOTRUN] subtest: Navigate a window via form-submission with javascript:-urls w/ default policy in report-only mode.
- PASS [expected NOTRUN] subtest: Navigate a frame via form-submission with javascript:-urls in enforcing mode.
- PASS [expected NOTRUN] subtest: Navigate a frame via form-submission with javascript:-urls w/ default policy in enforcing mode.
OK [expected TIMEOUT] /webstorage/localstorage-about-blank-3P-iframe-opens-3P-window.partitioned.html (#29053)
- PASS [expected TIMEOUT] subtest: StorageKey: test 3P about:blank window opened from a 3P iframe
CRASH [expected ERROR] /workers/Worker-constructor-proto.any.serviceworker.html

Stable unexpected results that are known to be intermittent (33)

OK /IndexedDB/idbcursor-continuePrimaryKey-exceptions.any.html (#39277)

FAIL [expected PASS] subtest: IDBCursor continuePrimaryKey() on object store cursor

assert_throws_dom: continuePrimaryKey() should throw if source is not an index function "function() {
        cursor.continuePrimaryKey(2, 2);
      }" threw object "TypeError: cursor.continuePrimaryKey is not a function" that is not a DOMException InvalidAccessError: property "code" is equal to undefined, expected 15

OK /IndexedDB/idbcursor-continuePrimaryKey-exceptions.any.worker.html (#39277)

FAIL [expected PASS] subtest: IDBCursor continuePrimaryKey() on object store cursor

assert_throws_dom: continuePrimaryKey() should throw if source is not an index function "function() {
        cursor.continuePrimaryKey(2, 2);
      }" threw object "TypeError: cursor.continuePrimaryKey is not a function" that is not a DOMException InvalidAccessError: property "code" is equal to undefined, expected 15

OK /IndexedDB/idbobjectstore_getAll.any.html (#39276)
- PASS [expected FAIL] subtest: Get all values with transaction.commit()
OK /IndexedDB/idbobjectstore_getAll.any.worker.html (#39400)
- PASS [expected FAIL] subtest: Get all values with transaction.commit()
OK /IndexedDB/idbrequest-onupgradeneeded.any.html (#38895)
- PASS [expected FAIL] subtest: indexedDB.delete called from upgradeneeded handler
- PASS [expected FAIL] subtest: Abort transaction before deleting database in upgradeneeded handler
- PASS [expected FAIL] subtest: Abort transaction after deleting database in upgradeneeded event handler
- PASS [expected FAIL] subtest: transaction oncomplete ordering relative to open request onsuccess
OK /IndexedDB/idbrequest-onupgradeneeded.any.worker.html (#38971)
- PASS [expected FAIL] subtest: indexedDB.delete called from upgradeneeded handler
- PASS [expected FAIL] subtest: Abort transaction before deleting database in upgradeneeded handler
- PASS [expected FAIL] subtest: Abort transaction after deleting database in upgradeneeded event handler
- PASS [expected FAIL] subtest: transaction oncomplete ordering relative to open request onsuccess

OK /IndexedDB/key-conversion-exceptions.any.html (#39305)

FAIL [expected PASS] subtest: IDBCursor continue() method with throwing/invalid keys

assert_throws_exactly: key conversion with throwing getter should rethrow function "() =&gt; {
      receiver[method](key);
    }" threw object "TypeError: receiver[method] is not a function" but we expected it to throw object "getter: throwing from getter"

FAIL [expected PASS] subtest: IDBCursor update() method with throwing/invalid keys

assert_throws_exactly: throwing getter should rethrow during clone function "() =&gt; {
      cursor.update(value);
    }" threw object "TypeError: cursor.update is not a function" but we expected it to throw object "getter: throwing from getter"

OK /IndexedDB/key-conversion-exceptions.any.worker.html (#39284)

FAIL [expected PASS] subtest: IDBCursor continue() method with throwing/invalid keys

assert_throws_exactly: key conversion with throwing getter should rethrow function "() =&gt; {
      receiver[method](key);
    }" threw object "TypeError: receiver[method] is not a function" but we expected it to throw object "getter: throwing from getter"

FAIL [expected PASS] subtest: IDBCursor update() method with throwing/invalid keys

assert_throws_exactly: throwing getter should rethrow during clone function "() =&gt; {
      cursor.update(value);
    }" threw object "TypeError: cursor.update is not a function" but we expected it to throw object "getter: throwing from getter"

OK /_mozilla/mozilla/getBoundingClientRect.html (#39668)
- FAIL [expected PASS] subtest: getBoundingClientRect 1
```
assert_equals: expected 62 but got 60.35
```
FAIL [expected PASS] /_mozilla/mozilla/sslfail.html (#10760)
TIMEOUT [expected OK] /_mozilla/mozilla/window_resize_event.html (#36741)
- TIMEOUT [expected PASS] subtest: Popup onresize event fires after resizeTo
```
Test timed out
```

OK /_webgl/conformance/textures/misc/texture-upload-size.html (#21770)

FAIL [expected PASS] subtest: WebGL test #77

assert_true: Texture was smaller than the expected size 2x2 expected true got false

FAIL [expected PASS] subtest: WebGL test #79

assert_true: getError expected: INVALID_VALUE. Was NO_ERROR : when calling texSubImage2D with the same texture upload with offset 1, 1 expected true got false

FAIL [expected PASS] subtest: WebGL test #81

assert_true: Texture was smaller than the expected size 2x2 expected true got false

FAIL [expected PASS] subtest: WebGL test #83

assert_true: getError expected: INVALID_VALUE. Was NO_ERROR : when calling texSubImage2D with the same texture upload with offset 1, 1 expected true got false

PASS [expected FAIL] subtest: WebGL test #85
PASS [expected FAIL] subtest: WebGL test #87
PASS [expected FAIL] subtest: WebGL test #89
PASS [expected FAIL] subtest: WebGL test #91

TIMEOUT /content-security-policy/inheritance/location-reload.html (#38983)
- FAIL [expected PASS] subtest: location.reload() of empty iframe.
```
assert_equals: Image should be blocked by CSP after reload. expected "img blocked" but got "img loaded"
```
OK /css/css-cascade/layer-cssom-order-reverse.html (#36094)
- PASS [expected FAIL] subtest: Delete layer invalidates @font-face
OK [expected ERROR] /fetch/fetch-later/quota/same-origin-iframe/multiple-iframes.https.window.html (#35176)
OK /fetch/metadata/generated/css-font-face.https.sub.tentative.html (#32732)
- PASS [expected FAIL] subtest: sec-fetch-user
OK /fetch/metadata/generated/css-font-face.sub.tentative.html (#34624)
- PASS [expected FAIL] subtest: sec-fetch-storage-access - Not sent to non-trustworthy same-origin destination
- PASS [expected FAIL] subtest: sec-fetch-storage-access - Not sent to non-trustworthy same-site destination
ERROR [expected OK] /focus/focus-event-after-switching-iframes.sub.html (#40368)
OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-same-origin-fragment.html (#20768)
- FAIL [expected PASS] subtest: Tests that a fragment navigation in the unload handler will not block the initial navigation
```
assert_equals: expected "" but got "#fragment"
```
OK /html/browsers/history/the-history-interface/traverse_the_history_4.html (#21383)
- PASS [expected FAIL] subtest: Multiple history traversals, last would be aborted
TIMEOUT /html/interaction/focus/the-autofocus-attribute/supported-elements.html (#24145)
- TIMEOUT [expected PASS] subtest: Non-HTMLElement should not support autofocus
```
Test timed out
```
OK /html/semantics/document-metadata/the-meta-element/pragma-directives/attr-meta-http-equiv-refresh/allow-scripts-flag-changing-2.html (#39703)
- FAIL [expected PASS] subtest: Meta refresh of the original iframe is not blocked if moved into a sandboxed iframe
```
uncaught exception: Error: assert_unreached: The iframe into which the meta was moved must not refresh Reached unreachable code
```
OK /html/semantics/forms/form-submission-0/multipart-formdata.window.html (#28725)
- PASS [expected FAIL] subtest: multipart/form-data: Basic File test (formdata event)
- PASS [expected FAIL] subtest: multipart/form-data: 0x00 in value (formdata event)
- PASS [expected FAIL] subtest: multipart/form-data: single quote in name (normal form)
OK /html/webappapis/user-prompts/print-during-unload.html (#35944)
- PASS [expected FAIL] subtest: print() during unload
OK [expected CRASH] /pointerevents/compat/pointerevent_touch-action_two-finger_interaction.html (#40418)
OK /preload/prefetch-document.html (#37210)
- PASS [expected FAIL] subtest: different-site document prefetch with 'as=document' should not be consumed
OK /preload/preload-error.sub.html (#37177)
- PASS [expected FAIL] subtest: 404 (image): main
- FAIL [expected PASS] subtest: 404 (style): main
```
assert_unreached: Should have rejected: undefined Reached unreachable code
```
- FAIL [expected PASS] subtest: 404 (script): main
```
assert_unreached: Should have rejected: undefined Reached unreachable code
```
- PASS [expected FAIL] subtest: CORS (fetch): main
OK /preload/preload-resource-match.https.html (#38088)
- PASS [expected FAIL] subtest: Loading font (anonymous) with link (no-cors) should discard the preloaded response
- PASS [expected FAIL] subtest: Loading font (anonymous) with link (use-credentials) should discard the preloaded response
CRASH [expected OK] /resource-timing/render-blocking-status-link.html (#41664)
TIMEOUT /resource-timing/test_resource_timing.html (#25720)
- PASS [expected FAIL] subtest: window.performance.getEntriesByName() and window.performance.getEntriesByNameType() return same data (xmlhttprequest)
- PASS [expected FAIL] subtest: PerformanceEntry has correct name, initiatorType, startTime, and duration (xmlhttprequest)
TIMEOUT /resource-timing/test_resource_timing.https.html (#25216)
- PASS [expected FAIL] subtest: window.performance.getEntriesByName() and window.performance.getEntriesByNameType() return same data (xmlhttprequest)
OK /touch-events/single-tap-when-touchend-listener-use-sync-xhr.html (#41175)
- PASS [expected FAIL] subtest: Click event should be fired when touchend opens synchronous XHR
TIMEOUT [expected OK] /trusted-types/trusted-types-navigation.html?01-05 (#38975)
- TIMEOUT [expected PASS] subtest: Navigate a window via anchor with javascript:-urls in report-only mode.
```
Test timed out
```
- NOTRUN [expected PASS] subtest: Navigate a window via anchor with javascript:-urls w/ default policy in report-only mode.
- NOTRUN [expected PASS] subtest: Navigate a frame via anchor with javascript:-urls in enforcing mode.

github-actions · 2026-01-10T03:00:25Z

✨ Try run (#20871372562) succeeded.

Signed-off-by: Euclid Ye <[email protected]>

TimvdLippe

Approving these new CRASH tests with the explanation from the PR and the understanding that the full implementation of pointer events will once again make these passing.

yezhizhen · 2026-01-13T14:06:46Z

Too many in the queue. Waiting a bit.

servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Jan 9, 2026

yezhizhen requested a review from xiaochengh January 9, 2026 12:41

yezhizhen commented Jan 9, 2026

View reviewed changes

yezhizhen added the T-linux-wpt Do a try run of the WPT label Jan 10, 2026

github-actions bot removed the T-linux-wpt Do a try run of the WPT label Jan 10, 2026

yezhizhen added 2 commits January 10, 2026 14:23

.

48b421c

Signed-off-by: Euclid Ye <[email protected]>

update expectation

44b523f

Signed-off-by: Euclid Ye <[email protected]>

yezhizhen force-pushed the webdrivre-move-noblock branch from 8669659 to 44b523f Compare January 10, 2026 06:23

This was referenced Jan 10, 2026

webdriver: Insert correct cancel action object #41819

Open

servodriver always sets a pointerId of 0 for move events #41250

Closed

TimvdLippe approved these changes Jan 13, 2026

View reviewed changes

servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Jan 13, 2026

yezhizhen added this pull request to the merge queue Jan 13, 2026

servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Jan 13, 2026

yezhizhen removed this pull request from the merge queue due to a manual request Jan 13, 2026

servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Jan 13, 2026

yezhizhen added this pull request to the merge queue Jan 13, 2026

servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Jan 13, 2026

yezhizhen removed this pull request from the merge queue due to a manual request Jan 13, 2026

servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Jan 13, 2026

yezhizhen added this pull request to the merge queue Jan 13, 2026

servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Jan 13, 2026

Merged via the queue into servo:main with commit c210392 Jan 13, 2026
37 checks passed

yezhizhen deleted the webdrivre-move-noblock branch January 13, 2026 23:50

servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Jan 13, 2026

This was referenced Jan 15, 2026

webdriver: Multi-touch support #41923

Open

script: Implement pointer events #41290

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

webdriver: Dispatch embedder `TouchEventType::Move`#41801

webdriver: Dispatch embedder `TouchEventType::Move`#41801
yezhizhen merged 2 commits intoservo:mainfrom
yezhizhen:webdrivre-move-noblock

yezhizhen commented Jan 9, 2026 •

edited

Loading

Uh oh!

yezhizhen left a comment •

edited

Loading

Uh oh!

yezhizhen Jan 9, 2026

Uh oh!

github-actions bot commented Jan 10, 2026

Uh oh!

github-actions bot commented Jan 10, 2026

Uh oh!

github-actions bot commented Jan 10, 2026

Uh oh!

TimvdLippe left a comment

Uh oh!

yezhizhen commented Jan 13, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	let action = self.touch_handler.on_touch_move(event.id, point);
	if let Some(action) = action {

Uh oh!

Conversation

yezhizhen commented Jan 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yezhizhen left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yezhizhen Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jan 10, 2026

Uh oh!

github-actions bot commented Jan 10, 2026

Uh oh!

github-actions bot commented Jan 10, 2026

Uh oh!

TimvdLippe left a comment

Choose a reason for hiding this comment

Uh oh!

yezhizhen commented Jan 13, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

yezhizhen commented Jan 9, 2026 •

edited

Loading

yezhizhen left a comment •

edited

Loading