script: revamp module script loading to follow current spec#41779
Merged
TimvdLippe merged 31 commits intoservo:mainfrom Jan 22, 2026
Merged
script: revamp module script loading to follow current spec#41779TimvdLippe merged 31 commits intoservo:mainfrom
TimvdLippe merged 31 commits intoservo:mainfrom
Conversation
Gae24
commented
Jan 8, 2026
Gae24
commented
Jan 10, 2026
|
🔨 Triggering try run (#20882753766) for Linux (WPT) |
|
Test results for linux-wpt from try job (#20882753766): Flaky unexpected result (40)
Stable unexpected results that are known to be intermittent (34)
Stable unexpected results (201)
|
|
|
|
🔨 Triggering try run (#20884464244) for Linux (WPT) |
|
Test results for linux-wpt from try job (#20884464244): Flaky unexpected result (36)
Stable unexpected results that are known to be intermittent (35)
Stable unexpected results (201)
|
|
|
|
🔨 Triggering try run (#20893348816) for Linux (WPT) |
|
Test results for linux-wpt from try job (#20893348816): Flaky unexpected result (29)
Stable unexpected results that are known to be intermittent (37)
Stable unexpected results (201)
|
|
|
|
🔨 Triggering try run (#20969496928) for Linux (WPT) |
|
Test results for linux-wpt from try job (#20969496928): Flaky unexpected result (39)
Stable unexpected results that are known to be intermittent (30)
Stable unexpected results (18)
|
|
|
|
🔨 Triggering try run (#21001225834) for Linux (WPT) |
|
Test results for linux-wpt from try job (#21001225834): Flaky unexpected result (46)
Stable unexpected results that are known to be intermittent (27)
Stable unexpected results (51)
|
Don't bail out from fetching a module if there's already a pending request to the same one, this is needed when encountering multiple times the same module, for each import statement is required to run onSingleFetchComplete algorithm. Fix borrow issue inside fetch_the_descendants_and_link_module_script. Switch visited to be a set of module's base url Signed-off-by: Gae24 <[email protected]>
Signed-off-by: Gae24 <[email protected]>
…arsing failures. Signed-off-by: Gae24 <[email protected]>
…s promise. Signed-off-by: Gae24 <[email protected]>
Signed-off-by: Gae24 <[email protected]>
Signed-off-by: Gae24 <[email protected]>
Signed-off-by: Gae24 <[email protected]>
Signed-off-by: Gae24 <[email protected]>
Signed-off-by: Gae24 <[email protected]>
Signed-off-by: Gae24 <[email protected]>
Signed-off-by: Gae24 <[email protected]>
- correctly identify ModuleTree that have a pending fetch. - pass None to notify_owner_to_finish only if module has a network error. - pass an error to gen_type_error, to comunicate the exact encountered failure. - use response url and not request url when creating a module script. Signed-off-by: Gae24 <[email protected]>
Signed-off-by: Gae24 <[email protected]>
Signed-off-by: Gae24 <[email protected]>
Signed-off-by: Gae24 <[email protected]>
Signed-off-by: Gae24 <[email protected]>
Signed-off-by: Gae24 <[email protected]>
Contributor
|
Very impressive work, @Gae24! 🙏 |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewrite module script fetching logic to follow current spec.
Testing: Covered by existing wpt tests
Fixes: #31397