mach: Break the shackle that restricts cross-compilation from Windows#41748
Merged
yezhizhen merged 1 commit intoservo:mainfrom Jan 8, 2026
Merged
mach: Break the shackle that restricts cross-compilation from Windows#41748yezhizhen merged 1 commit intoservo:mainfrom
yezhizhen merged 1 commit intoservo:mainfrom
Conversation
Signed-off-by: Euclid Ye <[email protected]>
servo-highfive
added
the
S-awaiting-review
sagudev
approved these changes
Jan 8, 2026
Member
sagudev
left a comment
sagudev
left a comment
There was a problem hiding this comment.
LGTM, but can you also add link to offending/workaround PR into this PR description (before merge so it will also get into commit).
servo-highfive
removed
the
S-awaiting-review
Member
Author
Updated. |
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I never forget that day: @dependabot updates aws-lc-rs, and cross-compilation Servo from Windows fails. We were left with two options:
Later, we've been restricted since #36070 to only use option 2 due to restrictions imposed here. But the system is innocent, and it is aws-lc-rs's responsibility to fix the rules. Still, @d-desiatkin and I believed that day would come, when we would return justice to the victim.
Freedom is better served late than never. It is now working normally since aws-lc-rs has fixed the rules.