Merged
Conversation
servo-highfive
added
the
S-awaiting-review
Narfinger
force-pushed
the
webxr-cleanup
branch
from
b905be6 to
af33917
Compare
Signed-off-by: Narfinger <[email protected]>
mrobinson
approved these changes
Jan 7, 2026
servo-highfive
removed
the
S-awaiting-review
Member
|
@Narfinger Thanks! I've been looking forward to this for a while. A good followup to this change would be to remove the |
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
webxr/webxr-api have the feature flag "ipc". This is required by important crates such as script and canvas. The only distinction was made in servo which does not use the IPC for android/ohos but because servo depends on script, this was essentially useless.
This PR removes the feature flag and cleans up the code related to it.
Testing: Compilation is the test.