Conversation
TimvdLippe
left a comment
There was a problem hiding this comment.
Nice work! This mostly looks good, but we are missing the concept of the Platform Object. If you implement that, I expect almost all tests to pass.
b2679c6 to
b59e604
Compare
b59e604 to
94d3470
Compare
TimvdLippe
left a comment
There was a problem hiding this comment.
Only some nits, we are almost there. Test results look a lot better already.
components/script/dom/origin.rs
Outdated
| return None; | ||
| } | ||
|
|
||
| if let Ok(area_obj) = root_from_handlevalue::<HTMLAreaElement>(value, cx) { |
There was a problem hiding this comment.
Instead of HTMLAreaElement, did you try to use HTMLHyperlinkElementUtils instead? That's what the spec uses and I would have thought that would have worked. If it doesn't, then the current approach is (unfortunately) the way to go.
There was a problem hiding this comment.
It's not a real interface, just a mixin:
. The Rust type is just a trait that we implement for certain DOM types.There was a problem hiding this comment.
I remember I tried HTMLHyperlinkElementUtils at first but it failed, so I changed it to HTMLAreaElement
|
🔨 Triggering try run (#20781151196) for Linux (WPT) |
|
Test results for linux-wpt from try job (#20781151196): Flaky unexpected result (33)
Stable unexpected results that are known to be intermittent (28)
Stable unexpected results (4)
|
|
|
You can safely add them to both of these interfaces tests. The other tests you can also update the test expectations for. You can use the following command to make that easier: Note that you need the GitHub CLI installed to make it run. |
94d3470 to
08ae061
Compare
TimvdLippe
left a comment
There was a problem hiding this comment.
One last change regarding the test expectations. The rest LGTM. Thank you!
08ae061 to
027f8b4
Compare
Signed-off-by: WaterWhisperer <[email protected]>
027f8b4 to
22ed911
Compare
Thanks for your guidance, it was an interesting and enjoyable exploration, and I learned a lot |
Testing:
./mach test-wpt /html/browsers/origin/api/Fixes: #41106