libservo: Extend SiteDataManager::clear_site_data to clear sessionStorage#41709
Merged
jdm merged 1 commit intoservo:mainfrom Jan 6, 2026
Merged
libservo: Extend SiteDataManager::clear_site_data to clear sessionStorage#41709jdm merged 1 commit intoservo:mainfrom
SiteDataManager::clear_site_data to clear sessionStorage#41709jdm merged 1 commit intoservo:mainfrom
Conversation
servo-highfive
added
the
S-awaiting-review
…torage sessionStorage entries are identified via their associated origins and removed across all browsing contexts. This brings sessionStorage in line with cookies, which were already handled by the API. Both public and private browsing contexts are included in the clearing operation. The necessary support has been added to the storage crate to clear WebStorage data. Signed-off-by: Jan Varga <[email protected]>
janvarga
force-pushed
the
clear-site-data-session
branch
from
7b843e2 to
24a0b5b
Compare
jdm
approved these changes
Jan 6, 2026
servo-highfive
removed
the
S-awaiting-review
servo-highfive
added
the
S-awaiting-merge
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
servo-highfive
added
S-tests-failed
Member
Author
|
It seems it was just an intermittent failure? |
servo-highfive
added
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sessionStorage entries are identified via their associated origins and removed
across all browsing contexts. This brings sessionStorage in line with cookies,
which were already handled by the API.
Both public and private browsing contexts are included in the clearing
operation.
The necessary support has been added to the storage crate to clear WebStorage
data.
Testing: A new integration test has been added.