servoshell: Support tracing-rs events when using hitrace#41708
Merged
jschwe merged 3 commits intoservo:mainfrom Jan 7, 2026
Merged
servoshell: Support tracing-rs events when using hitrace#41708jschwe merged 3 commits intoservo:mainfrom
jschwe merged 3 commits intoservo:mainfrom
Conversation
Member
|
@janeoa You need to sign-off your commits.
|
Signed-off-by: jane <[email protected]>
|
🔨 Triggering try run (#20755341755) for OpenHarmony |
jschwe
changed the title
Bencher Report
|
|
Signed-off-by: jane <[email protected]>
Signed-off-by: jane <[email protected]>
|
🔨 Triggering try run (#20782542624) for OpenHarmony |
|
✨ Try run (#20782542624) succeeded. |
servo-highfive
added
the
S-awaiting-review
servo-highfive
added
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small addition of "on_event" for HiTrace
When using the tracing-perfetto backend, servo did trace LargestContentfullPaint, (LCP) but when using hitrace, the traces lacked the LCP. This was due to the tracing subscriber implementation not handling tracing-rs events.
More on
on_eventcan be found here: https://docs.rs/tracing-subscriber/latest/tracing_subscriber/layer/trait.Layer.html#method.on_eventTesting: manually tested by adding and removing
--psn=--pref=largest_contentful_paint_enabled=true