ohos ci: Attempt to close USB mode popup#41695
Merged
yezhizhen merged 2 commits intoservo:mainfrom Jan 6, 2026
Merged
Conversation
Signed-off-by: Jonathan Schwender <[email protected]>
servo-highfive
added
the
S-awaiting-review
yezhizhen
approved these changes
Jan 6, 2026
servo-highfive
removed
the
S-awaiting-review
Signed-off-by: Euclid Ye <[email protected]>
servo-highfive
added
the
S-awaiting-review
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On OpenHarmony a system pop-up will appear, if a USB connection is established. This pop-up will overlay servo, and intercept touch events, such as a simulated slide event, causing the CI test to fail.
To avoid this, we now check if the focused window is servo, and attempt to close the pop-up speculatively by doing the
backaction, which dismisses regular dismissible popups. See also the relevant OpenHarmony documentationTesting: Manually tested the fix on a device locally and mach try
Fixes: #41608