net: Remove NetworkError::Internal#41693
Merged
TimvdLippe merged 1 commit intoservo:mainfrom Jan 6, 2026
Merged
Conversation
servo-highfive
added
the
S-awaiting-review
mrobinson
approved these changes
Jan 5, 2026
Member
mrobinson
left a comment
mrobinson
left a comment
There was a problem hiding this comment.
Nice. Do you mind restoring the Testing: line of the template before landing?
servo-highfive
removed
the
S-awaiting-review
Rather than this catch-all (which I copy-pasted from a usage where I should have introduced a specific enum value), we now should always use one of the enum values. If one does not exist, then it should be added as such. Follow-up for servo#36434 Signed-off-by: Tim van der Lippe <[email protected]>
TimvdLippe
force-pushed
the
remove-internal-network-error
branch
from
e0fbd75 to
2348e54
Compare
servo-highfive
added
the
S-awaiting-review
servo-highfive
added
the
S-awaiting-merge
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
servo-highfive
added
S-tests-failed
servo-highfive
added
S-awaiting-merge
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
servo-highfive
added
S-tests-failed
servo-highfive
added
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rather than this catch-all (which I copy-pasted from a usage where I should have introduced a specific enum value), we now should always use one of the enum values. If one does not exist, then it should be added as such.
Follow-up for #36434
Testing: it builds