script: Init and pass down &mut JSContext in script-related threads#41692
Merged
jdm merged 2 commits intoservo:mainfrom Jan 6, 2026
Merged
script: Init and pass down &mut JSContext in script-related threads#41692jdm merged 2 commits intoservo:mainfrom
jdm merged 2 commits intoservo:mainfrom
Conversation
Signed-off-by: sagudev <[email protected]>
Signed-off-by: sagudev <[email protected]>
jdm
approved these changes
Jan 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ScriptThread::get_safe_cxin favor ofRuntime::cx(this intentionally shadows RustRuntime::cx, which is not really safe with all other stuff that happen in servo).ScriptThread::newto accommodate those changes (we also need to pass cx for some other stuff).servo/components/script/dom/workers/workerglobalscope.rs
Line 1013 in 6ccc47f
So with this PR, we prepared all entry points of JSContext (or other should actually be reentering via SM callback or passed down from the root one in the thread).
Testing: No changes just safety, but it should be covered by WPT
Part of #40600