Skip to content

net: Support no_proxy and https_proxy#41689

Merged
TimvdLippe merged 3 commits intoservo:mainfrom
Narfinger:proxy-env
Jan 6, 2026
Merged

net: Support no_proxy and https_proxy#41689
TimvdLippe merged 3 commits intoservo:mainfrom
Narfinger:proxy-env

Conversation

@Narfinger
Copy link
Copy Markdown
Contributor

@Narfinger Narfinger commented Jan 5, 2026 •
edited by jschwe
Loading

This now respects the no_proxy and https_proxy variables with a matching pref (read from the environment).

We now have a new ProxyConnector which uses the hyper_util match to either construct a Tunnel or clone the ServoHttpConnector inside.

This could potentially be slower if every connection is proxied as we redo the tunnel for every new connection. I think this is how the structure is intended to be used as
technically the http_proxy variable can have different proxy assignments per uri.

Signed-off-by: Narfinger [email protected]

Testing: Tested via setting the no_proxy variable and testing those websites vs proxied websites.
Fixes: #41687

@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Jan 5, 2026
jschwe
jschwe reviewed Jan 5, 2026
View reviewed changes
@Narfinger
allow https_proxy
c22862b 
Signed-off-by: Narfinger <[email protected]>
jschwe
jschwe reviewed Jan 5, 2026
View reviewed changes
@Narfinger
added documentation
07102b8 
Signed-off-by: Narfinger <[email protected]>
@servo-highfive servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Jan 6, 2026
@jschwe jschwe changed the title net: Use no_proxy variable net: Support no_proxy and https_proxy Jan 6, 2026
@jschwe jschwe added this pull request to the merge queue Jan 6, 2026
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Jan 6, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 6, 2026
@servo-highfive servo-highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Jan 6, 2026
@TimvdLippe TimvdLippe added this pull request to the merge queue Jan 6, 2026
@servo-highfive servo-highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Jan 6, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 6, 2026
@servo-highfive servo-highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Jan 6, 2026
@TimvdLippe TimvdLippe added this pull request to the merge queue Jan 6, 2026
@servo-highfive servo-highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Jan 6, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 6, 2026
@servo-highfive servo-highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Jan 6, 2026
@yezhizhen
Copy link
Copy Markdown
Member

yezhizhen commented Jan 6, 2026

Seems to be a issue with Apache server, which contains Kotlin resource to build Android. I just tried and the resource can be fetched now. Let's run that test.

@yezhizhen yezhizhen added the T-android Do a try run on Android label Jan 6, 2026
@github-actions github-actions bot removed the T-android Do a try run on Android label Jan 6, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 6, 2026

🔨 Triggering try run (#20749145398) for Android

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 6, 2026

⚠️ Try run (#20749145398) failed!

@yezhizhen yezhizhen mentioned this pull request Jan 6, 2026
Merged
@yezhizhen
Copy link
Copy Markdown
Member

yezhizhen commented Jan 6, 2026 

A problem occurred configuring root project 'apk'.
> Could not resolve all artifacts for configuration ':classpath'.
   > Could not download kotlin-stdlib-jdk8-1.9.20.jar (org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.9.20)
      > Could not get resource 'https://repo.maven.apache.org/maven2/org/jetbrains/kotlin/kotlin-stdlib-jdk8/1.9.20/kotlin-stdlib-jdk8-1.9.20.jar'.
         > Could not GET 'https://repo.maven.apache.org/maven2/org/jetbrains/kotlin/kotlin-stdlib-jdk8/1.9.20/kotlin-stdlib-jdk8-1.9.20.jar'. Received status code 403 from server: Forbidden

I don't know why runner cannot get these.

@Narfinger
Copy link
Copy Markdown
Contributor Author

Narfinger commented Jan 6, 2026

There is some problem on github currently. There is already a discussion on zulip: #general > Android builds are busted atm

@TimvdLippe TimvdLippe added this pull request to the merge queue Jan 6, 2026
@servo-highfive servo-highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Jan 6, 2026
Merged via the queue into servo:main with commit ea48632 Jan 6, 2026
58 of 61 checks passed
@servo-highfive servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Jan 6, 2026
@Narfinger Narfinger deleted the proxy-env branch January 7, 2026 08:20
@jdm jdm mentioned this pull request Jan 9, 2026
Open
@yezhizhen yezhizhen mentioned this pull request Feb 4, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jschwe jschwe jschwe approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

NO_PROXY environment variable is currently not respected by servo.

5 participants

@Narfinger @yezhizhen @jschwe @TimvdLippe @servo-highfive