Unit Tests: Disable proxy for local tests#41688
Merged
TimvdLippe merged 1 commit intoservo:mainfrom Jan 5, 2026
Merged
Conversation
Signed-off-by: Narfinger <[email protected]>
servo-highfive
added
the
S-awaiting-review
servo-highfive
removed
the
S-awaiting-review
Narfinger
changed the title
Member
|
Thanks! |
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per #41687 we currently have a very simple proxy model without any respect to NO_PROXY. Hence, things such as localhost and 127.0.0.1 might be forwarded to the proxy which probably will not respond correctly.
This sets the preference for the ServoTest to not have any proxy (as it will be taken from the default environment variable otherwise).
Signed-off-by: Narfinger [email protected]
Testing: Run tests which previously did not work and now works.
Fixes: Unit Tests run on proxy machines produced wrong results.