Build/Canvas: Vello or Vello CPU feature flags#41686
Merged
TimvdLippe merged 1 commit intoservo:mainfrom Jan 5, 2026
Merged
Conversation
Narfinger
force-pushed
the
vello_or_vello_cpu
branch
from
1d741dc to
ee1b29a
Compare
Signed-off-by: Narfinger <[email protected]>
servo-highfive
added
the
S-awaiting-review
TimvdLippe
approved these changes
Jan 5, 2026
servo-highfive
removed
the
S-awaiting-review
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
Member
|
I think this change should be reverted. It is not an error to enable both canvas backends and they are configurable via a runtime option. With the change the runtime option no longer makes sense. It is a problem to not enable either. One potential fix would to make it so that the compile-time option only configures whether |
mrobinson
added a commit
to mrobinson/servo
that referenced
this pull request
Jan 5, 2026
This reverts commit fb239a1. This change makes it impossible to enable both canvas backends at the same time which isn't a problem at all.
Contributor
Author
|
The above PR can be easily changed to have the error only when no backend is selected. Is this preferable? |
mrobinson
added a commit
to mrobinson/servo
that referenced
this pull request
Jan 6, 2026
This reverts commit fb239a1. This change makes it impossible to enable both canvas backends at the same time which isn't a problem at all. Signed-off-by: Martin Robinson <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 6, 2026
) This reverts commit fb239a1 (#41686). This change makes it impossible to enable both canvas backends at the same time which isn't a problem at all. Signed-off-by: Martin Robinson <[email protected]>
Member
|
I left a comment on #41698 about this, but essentially if we are working toward being able to build Servo with just |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simple compile time check for only allowing one backend to be enabled. The error messages are sadly still full of other random errors but at least if people scroll up enough they are going to see the compile error.
Signed-off-by: Narfinger [email protected]
Testing: Tested with both flags and without both flags and both time we get an error.
Fixes: #40779