devtools: Implement ActorEncode and clean inspector sub-actors#41685
Merged
jdm merged 1 commit intoservo:mainfrom Jan 5, 2026
Merged
devtools: Implement ActorEncode and clean inspector sub-actors#41685jdm merged 1 commit intoservo:mainfrom
jdm merged 1 commit intoservo:mainfrom
Conversation
Signed-off-by: eri <[email protected]>
servo-highfive
added
the
S-awaiting-review
jdm
approved these changes
Jan 5, 2026
servo-highfive
removed
the
S-awaiting-review
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspector sub-actors (walker, highlighter and page-style) had an overly complicated creation mechanism using
RefCell<Option<...>>and instantiating these actors afterwards. Since the client always asks for the three actors and instantiating them isn't that expensive, we aren't saving anything from delaying this, and it introduces unnecessary complexity.For
*Msg, make inspector sub-actors follow the rest and implementActorEncodeinstead of manually creating the struct inhandle_message.Note that this change doesn't fix the issue with navigation/reloading breaking the inspector. I am planning to send a patch for that, but it is cleaner to separate this refactor and merge it before.
Testing: Manually test that the inspector still works.