script: Consolidate global initialization for fetch requests#41663
Merged
TimvdLippe merged 1 commit intoservo:mainfrom Jan 7, 2026
Merged
script: Consolidate global initialization for fetch requests#41663TimvdLippe merged 1 commit intoservo:mainfrom
TimvdLippe merged 1 commit intoservo:mainfrom
Conversation
|
🔨 Triggering try run (#20694814445) for Linux (WPT) |
Collaborator
|
🤖 Opened new upstream WPT pull request (web-platform-tests/wpt#56977) with upstreamable changes. |
|
Test results for linux-wpt from try job (#20694814445): Flaky unexpected result (28)
Stable unexpected results that are known to be intermittent (24)
Stable unexpected results (1)
|
|
|
901807f to
7ceafd2
Compare
|
🔨 Triggering try run (#20725173435) for Linux (WPT) |
Collaborator
|
📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#56977). |
7ceafd2 to
0ab33c4
Compare
Collaborator
|
📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#56977). |
|
Test results for linux-wpt from try job (#20725173435): Flaky unexpected result (30)
Stable unexpected results that are known to be intermittent (27)
|
|
✨ Try run (#20725173435) succeeded. |
0ab33c4 to
be06c1c
Compare
Collaborator
|
🤖 This change no longer contains upstreamable changes to WPT; closed existing upstream pull request (web-platform-tests/wpt#56977). |
jdm
approved these changes
Jan 6, 2026
Rather than having each callside specifying the relevant information from the GlobalScope, do this via a trait instead. This would have saved us quite a bit of test debugging since we would often forget to set relevant information from the global context for a request. Now, in the future when we need additional information from the globalscope for a request, we only need to update this method to make that happen. Previously it would also sometimes use `document`, but calling the relevant information on either `document` or `globalscope` doesn't matter, since the `globalscope` defers to the value from the `document` anyways. Signed-off-by: Tim van der Lippe <[email protected]>
be06c1c to
76fa909
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rather than having each callside specifying the relevant
information from the GlobalScope, do this via a trait instead.
This would have saved us quite a bit of test debugging
since we would often forget to set relevant information
from the global context for a request.
Now, in the future when we need additional information from
the globalscope for a request, we only need to update this
method to make that happen.
Previously it would also sometimes use
document, butcalling the relevant information on either
documentorglobalscopedoesn't matter, since theglobalscopedefers to the value from the
documentanyways.