Retry EventSource after temporary failures using is_permanent_failure#41651
Merged
jdm merged 2 commits intoservo:mainfrom Jan 4, 2026
Merged
Retry EventSource after temporary failures using is_permanent_failure#41651jdm merged 2 commits intoservo:mainfrom
is_permanent_failure#41651jdm merged 2 commits intoservo:mainfrom
Conversation
servo-highfive
added
the
S-awaiting-review
WaterWhisperer
force-pushed
the
retry-eventsource
branch
from
c68f1d2 to
7893ff3
Compare
servo-highfive
removed
the
S-awaiting-review
servo-highfive
added
the
S-awaiting-merge
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
servo-highfive
added
S-tests-failed
Member
Excellent, I was hoping there would be a CSP improvement. |
WaterWhisperer
force-pushed
the
retry-eventsource
branch
from
7893ff3 to
ce09651
Compare
servo-highfive
added
S-awaiting-review
WaterWhisperer
force-pushed
the
retry-eventsource
branch
from
ce09651 to
b15e289
Compare
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
Signed-off-by: WaterWhisperer <[email protected]>
Signed-off-by: WaterWhisperer <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add
is_permanent_failuremethod inNetworkErrorand call it from theEventSourceinstead of the current match against the url's schemeTesting:
./mach test-wpt tests/wpt/tests/eventsourceFixes: #41634