script: Skip some steps when determining encoding for XML document#41637
Merged
simonwuelker merged 2 commits intoservo:mainfrom Jan 2, 2026
Merged
script: Skip some steps when determining encoding for XML document#41637simonwuelker merged 2 commits intoservo:mainfrom
simonwuelker merged 2 commits intoservo:mainfrom
Conversation
Signed-off-by: Simon Wülker <[email protected]>
Signed-off-by: Simon Wülker <[email protected]>
servo-highfive
added
the
S-awaiting-review
servo-highfive
removed
the
S-awaiting-review
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
XML documents do not use the "determine the encoding" algorithm. As far as I can tell, it is unspecified how they should determine the encoding instead. We now check the BOM,
Content-Typeheader and prescan for an xml encoding declaration (but don't inherit encodings from iframes or attempt to determine the encoding from heuristics).Testing: New tests start to pass
Part of #6414