change #[allow]s to #[expect]s#41635
Merged
TimvdLippe merged 3 commits intoservo:mainfrom Jan 3, 2026
Merged
Conversation
TimurBora
requested review from
Loirooriol,
atbrakhi,
gterzian,
jschwe,
mrobinson,
nicoburns,
sagudev and
yezhizhen
as code owners
servo-highfive
added
S-awaiting-review
mrobinson
requested changes
Jan 2, 2026
Member
mrobinson
left a comment
mrobinson
left a comment
There was a problem hiding this comment.
Are there any new compilation warnings when you build with these changes?
servo-highfive
added
S-needs-code-changes
servo-highfive
added
S-awaiting-review
TimurBora
force-pushed
the
issue-40383
branch
2 times, most recently
from
2221ca6 to
68af9d6
Compare
Instead of the creation URL of the containing global, it should instead use the URL of the current worker. Despite the referrer specification stating that we should use the creation URL, instead browsers use the current URL. A new WPT test is added to cover that which we currently fail because of incorrect serialization of query parameters of a URL. But the actual redirect and all work now. Signed-off-by: Tim van der Lippe <[email protected]> Signed-off-by: TimurBora <[email protected]>
Changed almost allow to expects and removed the unfulfilled expectations, clippy::too_many_arguments mainly Testing: Refactor Part of: servo#40838 Signed-off-by: TimurBora <[email protected]>
mrobinson
previously requested changes
Jan 2, 2026
servo-highfive
added
S-needs-code-changes
mrobinson
reviewed
Jan 2, 2026
Changed almost allow to expects and removed the unfulfilled expectations, clippy::too_many_arguments mainly Testing: Refactor Part of: servo#40838 Signed-off-by: TimurBora <[email protected]>
servo-highfive
added
S-awaiting-review
TimvdLippe
approved these changes
Jan 3, 2026
Contributor
TimvdLippe
left a comment
TimvdLippe
left a comment
There was a problem hiding this comment.
Nice thanks for the cleanup!
servo-highfive
removed
the
S-awaiting-review
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed most #[allow]s to #[expect]s, mainly for clippy::too_many_arguments
Removed unfulfilled expectations
This is my first opensource contribution, so please let me know if anything should
be done differently.
Testing: Refactor
Part of: #40383