webdriver: Fix outdated timeouts test and remove redundant check by yezhizhen · Pull Request #41631 · servo/servo

yezhizhen · 2026-01-02T11:13:14Z

Initially the attempt is to validate params according to spec. But it turns out validation is already done at webdriver crate so I reverted the change.

But Chrome/Firefox are not compliant with spec: https://wpt.fyi/results/webdriver/tests/classic/new_session/timeouts.py?label=experimental&label=master&aligned. They only allow script timeouts to be None but not pageLoad and implicit, which is how the test is currently written.

Testing: Updated the test to be compliant with spec. New failures are because it is validated at webdriver crate.

servo-wpt-sync · 2026-01-02T11:16:25Z

🤖 Opened new upstream WPT pull request (web-platform-tests/wpt#56959) with upstreamable changes.

yezhizhen · 2026-01-02T11:43:33Z

Bugzilla link:
https://bugzilla.mozilla.org/show_bug.cgi?id=2008345

servo-wpt-sync · 2026-01-02T12:26:14Z

📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#56959).

servo-wpt-sync · 2026-01-02T13:45:47Z

📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#56959).

TimvdLippe · 2026-01-02T15:20:33Z

If Chrome and Firefox already behave like this, I think the specification editors typically update the spec instead of the browsers. Do you have a spec issue where browser vendors indicate they agree to update the behaviour? If not, I don't think we should update the test and instead match their behaviour and update the spec.

yezhizhen · 2026-01-03T01:37:49Z

If Chrome and Firefox already behave like this, I think the specification editors typically update the spec instead of the browsers. Do you have a spec issue where browser vendors indicate they agree to update the behaviour? If not, I don't think we should update the test and instead match their behaviour and update the spec.

No. The test is written 6 years ago and spec got updated. The upstream is being reviewed, and bug is confirmed in bugzilla link above.

Such things happen several times before, where the spec is ahead of vendors: e.g. window rect.

TimvdLippe · 2026-01-03T07:39:37Z

I can't find the link to the spec change. The Bugzilla link is for Firefox only. Can you provide the link to the commit/PR that changed the spec?

yezhizhen · 2026-01-04T12:07:06Z

@TimvdLippe Thanks for taking a look. I found it to be here: w3c/webdriver#1802.

The review's been delegated to web-platform-tests/wpt#56959, similar to #39988 before.

TimvdLippe

Sounds good! I approve this PR, but please don't merge until you have full approval on web-platform-tests/wpt#56959

yezhizhen · 2026-01-04T12:17:07Z

Sounds good! I approve this PR, but please don't merge until you have full approval on web-platform-tests/wpt#56959

Definitely!

Signed-off-by: Euclid Ye <[email protected]>

servo-wpt-sync · 2026-01-05T08:17:31Z

📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#56959).

yezhizhen · 2026-01-05T10:55:40Z

components/webdriver_server/timeout.rs

-                    WebDriverError::new(ErrorStatus::InvalidArgument, "Invalid value for {key}")
-                })? as u64),
+                Value::Number(num) => Some(
+                    num.as_u64()


My bad. It panicked with 2.0, which is valid according to spec.

Signed-off-by: Euclid Ye <[email protected]>

servo-wpt-sync · 2026-01-05T11:08:02Z

📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#56959).

github-actions · 2026-01-05T11:25:43Z

🔨 Triggering try run (#20713924804) for Linux (WPT)

github-actions · 2026-01-05T11:39:05Z

Test results for linux-wpt from try job (#20713924804):

Flaky unexpected result (1)

OK /webdriver/tests/classic/perform_actions/wheel.py
- ERROR [expected PASS] subtest: test_null_response_value
```
teardown error: 
```
- ERROR [expected PASS] subtest: test_no_top_browsing_context
```
setup error: ConnectionRefusedError: [Errno 111] Connection refused
```
- ERROR [expected PASS] subtest: test_no_browsing_context
```
setup error: ConnectionRefusedError: [Errno 111] Connection refused
```
- ERROR [expected PASS] subtest: test_params_actions_origin_outside_viewport[element]
```
setup error: ConnectionRefusedError: [Errno 111] Connection refused
```
- ERROR [expected PASS] subtest: test_params_actions_origin_outside_viewport[viewport]
```
setup error: ConnectionRefusedError: [Errno 111] Connection refused
```
- ERROR [expected PASS] subtest: test_scroll_not_scrollable
```
setup error: ConnectionRefusedError: [Errno 111] Connection refused
```
- ERROR [expected PASS] subtest: test_scroll_scrollable_overflow
```
setup error: ConnectionRefusedError: [Errno 111] Connection refused
```
- ERROR [expected PASS] subtest: test_scroll_iframe
```
setup error: ConnectionRefusedError: [Errno 111] Connection refused
```
- ERROR [expected PASS] subtest: test_scroll_shadow_tree[outer-open]
```
setup error: ConnectionRefusedError: [Errno 111] Connection refused
```
- ERROR [expected PASS] subtest: test_scroll_shadow_tree[outer-closed]
```
setup error: ConnectionRefusedError: [Errno 111] Connection refused
```
- And 3 more unexpected results...

github-actions · 2026-01-05T11:39:13Z

✨ Try run (#20713924804) succeeded.

servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Jan 2, 2026

servo-wpt-sync mentioned this pull request Jan 2, 2026

webdriver: Fix outdated timeouts test and remove redundant check web-platform-tests/wpt#56959

Merged

yezhizhen requested a review from xiaochengh January 2, 2026 12:29

TimvdLippe approved these changes Jan 4, 2026

View reviewed changes

servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Jan 4, 2026

yezhizhen added 7 commits January 5, 2026 16:01

Improve timeouts setup

0353e8c

Signed-off-by: Euclid Ye <[email protected]>

Remove validation

e93b4c3

Signed-off-by: Euclid Ye <[email protected]>

Update outdated WPT

9f60e68

Signed-off-by: Euclid Ye <[email protected]>

Use cartesian product to test combinations

0faa6c4

Signed-off-by: Euclid Ye <[email protected]>

Update invalid timeout tests

2053cbb

Signed-off-by: Euclid Ye <[email protected]>

Use the closest invalid value

f622c51

Signed-off-by: Euclid Ye <[email protected]>

Rename + Add test_invalid_timeouts_type

a787aab

Signed-off-by: Euclid Ye <[email protected]>

yezhizhen force-pushed the go branch from 901e5c5 to a787aab Compare January 5, 2026 08:14

servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Jan 5, 2026

yezhizhen added this pull request to the merge queue Jan 5, 2026

servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Jan 5, 2026

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 5, 2026

servo-highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Jan 5, 2026

yezhizhen commented Jan 5, 2026

View reviewed changes

yezhizhen added 2 commits January 5, 2026 19:02

Fix panic

7a9f7d9

Signed-off-by: Euclid Ye <[email protected]>

Update neglected tests

6996c25

Signed-off-by: Euclid Ye <[email protected]>

servo-highfive removed the S-tests-failed The changes caused existing tests to fail. label Jan 5, 2026

yezhizhen enabled auto-merge January 5, 2026 11:06

yezhizhen disabled auto-merge January 5, 2026 11:07

yezhizhen added the T-webdriver Do a try run of the WebDriver conformance tests label Jan 5, 2026

github-actions bot removed the T-webdriver Do a try run of the WebDriver conformance tests label Jan 5, 2026

yezhizhen added this pull request to the merge queue Jan 5, 2026

servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Jan 5, 2026

Merged via the queue into servo:main with commit 0022d97 Jan 5, 2026
47 checks passed

yezhizhen deleted the go branch January 5, 2026 12:29

servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Jan 5, 2026

Uh oh!

Conversation

yezhizhen commented Jan 2, 2026

Uh oh!

servo-wpt-sync commented Jan 2, 2026

Uh oh!

yezhizhen commented Jan 2, 2026

Uh oh!

servo-wpt-sync commented Jan 2, 2026

Uh oh!

servo-wpt-sync commented Jan 2, 2026

Uh oh!

TimvdLippe commented Jan 2, 2026

Uh oh!

yezhizhen commented Jan 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TimvdLippe commented Jan 3, 2026

Uh oh!

yezhizhen commented Jan 4, 2026

Uh oh!

TimvdLippe left a comment

Choose a reason for hiding this comment

Uh oh!

yezhizhen commented Jan 4, 2026

Uh oh!

servo-wpt-sync commented Jan 5, 2026

Uh oh!

Uh oh!

yezhizhen Jan 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

servo-wpt-sync commented Jan 5, 2026

Uh oh!

github-actions bot commented Jan 5, 2026

Uh oh!

github-actions bot commented Jan 5, 2026

Uh oh!

github-actions bot commented Jan 5, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

yezhizhen commented Jan 3, 2026 •

edited

Loading

yezhizhen Jan 5, 2026 •

edited

Loading