Skip to content

script: Implement import key operations of ML-DSA#41628

Merged
TimvdLippe merged 1 commit intoservo:mainfrom
kkoyung:ml-dsa-import
Jan 2, 2026
Merged

script: Implement import key operations of ML-DSA#41628
TimvdLippe merged 1 commit intoservo:mainfrom
kkoyung:ml-dsa-import

Conversation

@kkoyung
Copy link
Copy Markdown
Member

@kkoyung kkoyung commented Jan 2, 2026

Start adding ML-DSA support to WebCrypto API.

This patch implements the import key operations of ML-DSA, with ml-dsa crate.

Specification: https://wicg.github.io/webcrypto-modern-algos/#ml-dsa-operations-import-key

Testing:

  • Pass some WPT tests that were expected to fail.
  • Some new FAIL expectations are added. They were skipped by WPT when the import key operations of ML-DSA had not been implemented, and requires other not-yet-implemented operations to pass.

Fixes: Part of #41626

Start adding ML-DSA support to WebCrypto API.

This patch implements the import key operations of ML-DSA, with `ml-dsa`
crate.

Specification: https://wicg.github.io/webcrypto-modern-algos/#ml-dsa-operations-import-key

Testing:
- Pass some WPT tests that were expected to fail.
- Some new FAIL expectations are added. They were skipped by WPT when
  the import key operations of ML-DSA had not been implemented, and
  requires other not-yet-implemented operations to pass.

Fixes: Part of 41626

Signed-off-by: Kingsley Yung <[email protected]>
@kkoyung kkoyung requested a review from gterzian as a code owner January 2, 2026 09:01
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Jan 2, 2026
@servo-highfive servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Jan 2, 2026
@TimvdLippe TimvdLippe added this pull request to the merge queue Jan 2, 2026
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Jan 2, 2026
Merged via the queue into servo:main with commit df9877a Jan 2, 2026
32 checks passed
@servo-highfive servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Jan 2, 2026
@kkoyung kkoyung deleted the ml-dsa-import branch January 9, 2026 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants