script: Fix alg field of exported ML-KEM key in JWK format#41627
Merged
yezhizhen merged 2 commits intoservo:mainfrom Jan 2, 2026
Merged
script: Fix alg field of exported ML-KEM key in JWK format#41627yezhizhen merged 2 commits intoservo:mainfrom
alg field of exported ML-KEM key in JWK format#41627yezhizhen merged 2 commits intoservo:mainfrom
Conversation
We wrongly use the object identifier of ML-KEM for the `alg` field of exported ML-KEM key in JWK format. We should use the values specified in Section 8 of [draft-ietf-jose-pqc-kem-01] (Figure 1) instead. [draft-ietf-jose-pqc-kem-01] (Figure 1): https://www.ietf.org/archive/id/draft-ietf-jose-pqc-kem-01.html#direct-table Testing: WPT currently does not have relevant tests for ML-KEM keys in JWK format since The JWK format for ML-KEM is not standardized yet. We aim to remain compliant with the current specification. Signed-off-by: Kingsley Yung <[email protected]>
servo-highfive
added
the
S-awaiting-review
yezhizhen
reviewed
Jan 2, 2026
| ALG_ML_KEM_512 => ID_ALG_ML_KEM_512, | ||
| ALG_ML_KEM_768 => ID_ALG_ML_KEM_768, | ||
| ALG_ML_KEM_1024 => ID_ALG_ML_KEM_1024, | ||
| ALG_ML_KEM_512 => "MLKEM512", |
Member
There was a problem hiding this comment.
Can you put the reference link above?
yezhizhen
approved these changes
Jan 2, 2026
servo-highfive
removed
the
S-awaiting-review
Signed-off-by: Kingsley Yung <[email protected]>
servo-highfive
added
the
S-awaiting-review
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We wrongly use the object identifier of ML-KEM for the
algfield of exported ML-KEM key in JWK format. We should use the values specified in Section 8 of [draft-ietf-jose-pqc-kem-01] (Figure 1) instead.[draft-ietf-jose-pqc-kem-01] (Figure 1):
https://www.ietf.org/archive/id/draft-ietf-jose-pqc-kem-01.html#direct-table
Testing: WPT currently does not have relevant tests for ML-KEM keys in JWK format since The JWK format for ML-KEM is not standardized yet. We strive to remain compliant with the current specification.