Skip to content

ohos CI: pass through results of optional jobs to try-label result#41601

Merged
jschwe merged 2 commits intomainfrom
jschwender/ohos-ci-status
Jan 5, 2026
Merged

ohos CI: pass through results of optional jobs to try-label result#41601
jschwe merged 2 commits intomainfrom
jschwender/ohos-ci-status

Conversation

@jschwe
Copy link
Copy Markdown
Member

@jschwe jschwe commented Dec 31, 2025 •
edited
Loading

This allows the try result comment to notify the user if jobs, which don't block the MQ failed when running try-label jobs.

Testing: Tested by adding two DROP ME commits, which change the trigger from pull_request_target to push, which allows us to test the workflow, while retaining access to self-hosted runners and PR comment permissions. These commits will be removed before merging, and should be ignored during review.
See #41601 (comment) for a comment created with an optional job failing (by patching the job to fail).
Fixes: #40589

@jschwe jschwe changed the title Jschwender/ohos ci status Draft: ohos CI: pass through results of optional jobs to try-label result Dec 31, 2025
@jschwe jschwe mentioned this pull request Dec 31, 2025
Closed
@jschwe jschwe force-pushed the jschwender/ohos-ci-status branch from 1a97afb to 75adcd1 Compare December 31, 2025 11:13
@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 31, 2025

🔨 Triggering try run (#20617839157) for OpenHarmony

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 31, 2025

🔨 Triggering try run (#20618942171) for OpenHarmony

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 31, 2025

✨ Try run (#20618942171) succeeded.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 31, 2025

🔨 Triggering try run (#20619521715) for OpenHarmony

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 31, 2025

✨ Try run (#20619521715) succeeded.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 31, 2025

🔨 Triggering try run (#20621200555) for OpenHarmony

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 31, 2025

🔨 Triggering try run (#20621781884) for OpenHarmony

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 31, 2025

🔨 Triggering try run (#20622198169) for OpenHarmony

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 31, 2025

🔨 Triggering try run (#20622755194) for OpenHarmony

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 31, 2025

✨ Try run (#20622755194) succeeded.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 31, 2025

🔨 Triggering try run (#20623401760) for OpenHarmony

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 31, 2025

✨ Try run (#20623401760) succeeded.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 31, 2025

🔨 Triggering try run (#20623880766) for OpenHarmony

@jschwe jschwe force-pushed the jschwender/ohos-ci-status branch from cbae1be to fd12fb9 Compare January 1, 2026 13:10
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 1, 2026

🔨 Triggering try run (#20639098868) for OpenHarmony

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 1, 2026

⚠️ Try run (#20640422567) succeeded with failures of jobs that don't block the Merge Queue. Please check the workflow run for details.

@jschwe jschwe force-pushed the jschwender/ohos-ci-status branch from a9e8ad9 to cc2f7e7 Compare January 1, 2026 14:51
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 1, 2026

🔨 Triggering try run (#20640560617) for OpenHarmony

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 1, 2026

⚠️ Try run (#20640560617) succeeded with failures of jobs that don't block the Merge Queue. Please check the workflow run for details.

@jschwe jschwe force-pushed the jschwender/ohos-ci-status branch from cc2f7e7 to b3c7e89 Compare January 1, 2026 16:55
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 1, 2026

🔨 Triggering try run (#20642179850) for OpenHarmony

jschwe added 2 commits January 1, 2026 17:58
@jschwe
CI: pass through results
dbdabf8 
Signed-off-by: Jonathan Schwender <[email protected]>
@jschwe
Simplify try comment by using gh and update message
6e4b936 
Signed-off-by: Jonathan Schwender <[email protected]>
@jschwe jschwe force-pushed the jschwender/ohos-ci-status branch from b3c7e89 to 8f10ae7 Compare January 1, 2026 17:02
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 1, 2026

🔨 Triggering try run (#20642265865) for OpenHarmony

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 1, 2026

⚠️ Try run (#20642179850) succeeded with failures of jobs that don't block the Merge Queue. Please check the workflow run for details.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 1, 2026

🔨 Triggering try run (#20642558524) for OpenHarmony

@jschwe jschwe marked this pull request as ready for review January 1, 2026 17:22
@jschwe jschwe requested a review from sagudev as a code owner January 1, 2026 17:22
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Jan 1, 2026
@jschwe jschwe changed the title Draft: ohos CI: pass through results of optional jobs to try-label result ohos CI: pass through results of optional jobs to try-label result Jan 1, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 1, 2026

⚠️ Try run (#20642265865) succeeded with failures of jobs that don't block the Merge Queue. Please check the workflow run for details.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 1, 2026

✨ Try run (#20642558524) succeeded.

sagudev
sagudev approved these changes Jan 5, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@sagudev sagudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting way of testing this, but do not forget to revert testing commit.

@servo-highfive servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Jan 5, 2026
@jschwe jschwe force-pushed the jschwender/ohos-ci-status branch from c0accef to 6e4b936 Compare January 5, 2026 16:20
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Jan 5, 2026
@jschwe jschwe added this pull request to the merge queue Jan 5, 2026
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Jan 5, 2026
Merged via the queue into main with commit dc1f615 Jan 5, 2026
32 checks passed
@jschwe jschwe deleted the jschwender/ohos-ci-status branch January 5, 2026 19:12
@servo-highfive servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Jan 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sagudev sagudev sagudev approved these changes

Assignees

No one assigned

Labels

S-awaiting-review There is new code that needs to be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CI: Support failed continue-on-error jobs in try result comment on PRs

3 participants

@jschwe @sagudev @servo-highfive