net: Keep track of size of keep-alive records#41457
Conversation
|
🔨 Triggering try run (#20411389286) for Linux (WPT) |
|
🤖 Opened new upstream WPT pull request (web-platform-tests/wpt#56894) with upstreamable changes. |
|
Test results for linux-wpt from try job (#20411389286): Flaky unexpected result (33)
Stable unexpected results that are known to be intermittent (32)
Stable unexpected results (2)
|
|
|
ad52216 to
de72175
Compare
|
📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#56894). |
de72175 to
3cc073e
Compare
|
📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#56894). |
3cc073e to
4c3947d
Compare
|
📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#56894). |
|
🔨 Triggering try run (#20693721174) for Linux (WPT) |
4c3947d to
558d1b4
Compare
|
📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#56894). |
|
✍ Updated existing upstream WPT pull request (web-platform-tests/wpt#56894) title and body. |
|
Test results for linux-wpt from try job (#20693721174): Flaky unexpected result (32)
Stable unexpected results that are known to be intermittent (23)
Stable unexpected results (1)
|
|
|
|
I cannot reproduce the |
558d1b4 to
0c15c0b
Compare
|
📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#56894). |
|
0c15c0b to
32ac43d
Compare
|
📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#56894). |
jdm
left a comment
There was a problem hiding this comment.
Looks pretty reasonable! Just one request and one question.
|
|
||
| payload_parts = list(filter(None, payload.split(b":"))) | ||
| if len(payload_parts) > 0: | ||
| if len(payload_parts) > 1: |
There was a problem hiding this comment.
If a browser is not compliant, the WPT tests send invalid requests to the webserver. Prior to this change, the webserver would then error while processing the request. After the change, it correctly handles it, and the tests still fail since the requests shouldn't have fired in the first place.
32ac43d to
0823197
Compare
|
📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#56894). |
This adds the relevant information on a request client so that the http_loader can sum it up and check whether a keep-alive request is allowed to be sent. Signed-off-by: Tim van der Lippe <[email protected]>
0823197 to
aa98e10
Compare
|
📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#56894). |
These keep-alive records live on the
CoreResourceManagersince the vecof records must be modified by the fetch thread. The script thread sometimes
requires this information as well, which is why it can send a message to
obtain the total size.
The keep-alive records must be tracked per global. That's why all code needs
to specify the
pipeline_id. Requests optionally have this field, which is whythe code expects it to be present. The relevant information is added to the
navigator request to ensure it can compute it.
Fixes #41230