script: Reload the page when an incompatible encoding is detected during parsing#41430
script: Reload the page when an incompatible encoding is detected during parsing#41430simonwuelker wants to merge 7 commits intoservo:mainfrom
Conversation
733abfc to
e38dd9b
Compare
|
🔨 Triggering try run (#20396065715) for Linux (WPT) |
| ServoParser::parse_html_document( | ||
| &document, | ||
| Some(compliant_string), | ||
| url, | ||
| None, | ||
| EncodingInformation::UnknownOrIrrelevant, | ||
| can_gc, | ||
| ); |
There was a problem hiding this comment.
"Parse HTML from a string" should not need an encoding but we currently use ServoParser::parse_html_document for everything, even parsing network input.
I'll probably fix this in a followup.
e38dd9b to
092aaa2
Compare
|
Test results for linux-wpt from try job (#20396065715): Flaky unexpected result (32)
Stable unexpected results that are known to be intermittent (28)
Stable unexpected results (23)
|
|
|
ce0fd14 to
5e2b2f1
Compare
|
🔨 Triggering try run (#20410604739) for Linux (WPT) |
|
|
Test results for linux-wpt from try job (#20410604739): Flaky unexpected result (33)
Stable unexpected results that are known to be intermittent (29)
Stable unexpected results (18)
|
|
|
9b9270d to
128800f
Compare
|
🔨 Triggering try run (#20689847535) for Linux (WPT) |
|
Test results for linux-wpt from try job (#20689847535): Flaky unexpected result (36)
Stable unexpected results that are known to be intermittent (22)
Stable unexpected results (16)
|
|
|
|
Looks like there are quite a few failures around dynamically inserting |
Signed-off-by: Simon Wülker <[email protected]> Co-authored-by: Josh Matthews <[email protected]>
Signed-off-by: Simon Wülker <[email protected]>
Signed-off-by: Simon Wülker <[email protected]>
Signed-off-by: Simon Wülker <[email protected]>
Signed-off-by: Simon Wülker <[email protected]>
Signed-off-by: Simon Wülker <[email protected]>
128800f to
4d13984
Compare
|
🤖 Opened new upstream WPT pull request (web-platform-tests/wpt#56975) with upstreamable changes. |
|
🔨 Triggering try run (#20692347080) for Linux (WPT) |
Signed-off-by: Simon Wülker <[email protected]>
|
📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#56975). |
|
Test results for linux-wpt from try job (#20692347080): Flaky unexpected result (31)
Stable unexpected results that are known to be intermittent (23)
Stable unexpected results (13)
|
|
|
|
Closing in favor of #41730 |
This continues #41376. With this change servo will properly parse
<meta charset> and<meta http-equiv="content-type">tags and reload the page when appropriate.Encoding hints encountered during dynamic markup insertion (such as
document.write) or when the encoding does not matter (such as duringDOMParser.parseFromString) are ignored.@jdm I've added you as a co-author on the commit, since I used https://gist.github.com/jdm/1f08c1b8b3c33d3f5c44882a1b5eb822 which you posted earlier this year on zulip.
Companion PR for servo/html5ever#702
Fixes #24898
Closes #6414