libservo: Stop exporting ipc-channel for gamepad responders and use callbacks#41412
Merged
jdm merged 16 commits intoservo:mainfrom Jan 6, 2026
Merged
libservo: Stop exporting ipc-channel for gamepad responders and use callbacks#41412jdm merged 16 commits intoservo:mainfrom
ipc-channel for gamepad responders and use callbacks#41412jdm merged 16 commits intoservo:mainfrom
Conversation
Narfinger
requested review from
atbrakhi,
gterzian and
jschwe
as code owners
servo-highfive
added
the
S-awaiting-review
mrobinson
reviewed
Dec 19, 2025
mrobinson
approved these changes
Dec 21, 2025
Member
mrobinson
left a comment
mrobinson
left a comment
There was a problem hiding this comment.
Looks good. Please address the following comments before landing:
servo-highfive
removed
the
S-awaiting-review
mrobinson
changed the title
ipc-channel for gamepad responders and use callbacks
Member
|
FYI, there are conflicts to solve. |
servo-highfive
added
S-awaiting-review
Signed-off-by: Narfinger <[email protected]>
Signed-off-by: Narfinger <[email protected]>
Co-authored-by: Martin Robinson <[email protected]> Signed-off-by: Narfinger <[email protected]>
Co-authored-by: Martin Robinson <[email protected]> Signed-off-by: Narfinger <[email protected]>
Co-authored-by: Martin Robinson <[email protected]> Signed-off-by: Narfinger <[email protected]>
Co-authored-by: Martin Robinson <[email protected]> Signed-off-by: Narfinger <[email protected]>
Co-authored-by: Martin Robinson <[email protected]> Signed-off-by: Narfinger <[email protected]>
Co-authored-by: Martin Robinson <[email protected]> Signed-off-by: Narfinger <[email protected]>
Co-authored-by: Martin Robinson <[email protected]> Signed-off-by: Narfinger <[email protected]>
Co-authored-by: Martin Robinson <[email protected]> Signed-off-by: Narfinger <[email protected]>
Co-authored-by: Martin Robinson <[email protected]> Signed-off-by: Narfinger <[email protected]>
Narfinger
force-pushed
the
generic-channel-servoshell
branch
from
b93846b to
355cddc
Compare
Signed-off-by: Narfinger <[email protected]>
Signed-off-by: Narfinger <[email protected]>
Signed-off-by: Narfinger <[email protected]>
Signed-off-by: Narfinger <[email protected]>
mrobinson
approved these changes
Jan 6, 2026
servo-highfive
removed
the
S-awaiting-review
servo-highfive
added
the
S-awaiting-merge
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
servo-highfive
added
S-tests-failed
Member
|
Same as #41689 (comment) |
servo-highfive
added
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this we stop exporting ipc-channel in libservo and switch to GenericChannel/GenericCallback.
Testing: Generic Channels are tested all over the place.