script: Implement pointer events#41290
Conversation
simonwuelker
left a comment
There was a problem hiding this comment.
I'm not familiar enough with this part of the code to actually review it, but here are some immediate thoughts I had.
2b3883f to
0f10a6a
Compare
|
🤖 Opened new upstream WPT pull request (web-platform-tests/wpt#56897) with upstreamable changes. |
287fb9b to
5fb2c47
Compare
|
📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#56897). |
1 similar comment
|
📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#56897). |
|
What is the status of this PR? Can you rebase given that #41801 is merged. |
5fb2c47 to
63ae8e8
Compare
|
📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#56897). |
|
🔨 Triggering try run (#21124921967) for Linux (WPT) |
|
Test results for linux-wpt from try job (#21124921967): Flaky unexpected result (32)
Stable unexpected results that are known to be intermittent (30)
Stable unexpected results (3)
|
|
|
There are new unexpected failures in https://github.com/webbeef/servo/actions/runs/21124024992 and it looks like we still don't pass I won't have much time to check, so feel free to take over if you want @yezhizhen |
63ae8e8 to
4757979
Compare
|
📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#56897). |
|
@Gae24 I feel it's ready and would do some of the missing parts in follow ups. |
4757979 to
4a2d6c5
Compare
|
I'm running a new try build to check if the latest wpt update changes our results. |
3008e52 to
4dc1b0f
Compare
The last WPT update included web-platform-tests/wpt@c556bde that caused our expectations to change. |
|
📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#56897). |
|
I reverted the webdriver changes, try run here: https://github.com/webbeef/servo/actions/runs/21849393293/job/63056309331 I think we should take #42485 before. |
|
@webbeef It's ok. Let's do this incrementally and merge this first. I have a touch related PR that also depends on this. |
Remaining failures are due to the missing implementation of the pointer capture and pointer lock APIs, as well as: Requires User Activation support: /html/user-activation/activation-trigger-pointerevent.html?mouse Blocked on servo#41227 : /pointerevents/compat/pointerevent_mouse-pointer-on-scrollbar.html Requires persistentDeviceId: /pointerevents/persistentDeviceId/get-persistendeviceid-from-pointer-event.tentative.html /pointerevents/persistentDeviceId/get-persistendeviceid-from-pointer-mouse-event.tentative.html Requires pointerenter, pointerover, pointerout, pointerleave events: /pointerevents/pointerevent_pointerId_scope.html Requires pointerrawupdate event: /pointerevents/pointerevent_pointerrawupdate.html /pointerevents/pointerevent_pointerrawupdate.https.html Consider implementing non-standard attributes toElement and fromElement: See https://w3c.github.io/pointerevents/#attributes-and-default-actions Fails because the pointerId is always 0 for pointermove, maybe caused by commit 7b00b54 : /pointerevents/pointerevent_pointermove_isprimary_same_as_pointerdown.html?touch servo#41250 Signed-off-by: webbeef <[email protected]>
4dc1b0f to
f197100
Compare
|
📝 Transplanted new upstreamable changes to existing upstream WPT pull request (web-platform-tests/wpt#56897). |
Remaining failures are due to the missing implementation of the pointer capture and pointer lock APIs, as well as:
Requires User Activation support:
/html/user-activation/activation-trigger-pointerevent.html?mouse
Blocked on #41227 : /pointerevents/compat/pointerevent_mouse-pointer-on-scrollbar.html
Requires persistentDeviceId:
/pointerevents/persistentDeviceId/get-persistendeviceid-from-pointer-event.tentative.html /pointerevents/persistentDeviceId/get-persistendeviceid-from-pointer-mouse-event.tentative.html
Requires pointerenter, pointerover, pointerout, pointerleave events: /pointerevents/pointerevent_pointerId_scope.html
Requires pointerrawupdate event:
/pointerevents/pointerevent_pointerrawupdate.html
/pointerevents/pointerevent_pointerrawupdate.https.html
Consider implementing non-standard attributes toElement and fromElement: See https://w3c.github.io/pointerevents/#attributes-and-default-actions
Fails because the pointerId is always 0 for pointermove, maybe caused by commit 7b00b54 : /pointerevents/pointerevent_pointermove_isprimary_same_as_pointerdown.html?touch #41250
Testing: Updated wpt expectations
Fixes: #38435