prefs: Handle uppercase HTTP_PROXY variable#41268
Merged
yezhizhen merged 3 commits intoservo:mainfrom Dec 15, 2025
Merged
Conversation
follow up to servo#41209 Signed-off-by: tho <[email protected]>
servo-highfive
added
the
S-awaiting-review
yezhizhen
requested changes
Dec 15, 2025
Member
There was a problem hiding this comment.
Firefox does just that at https://github.com/mozilla-firefox/firefox/blob/bef781bbd7a225c428c2444d7d02e9f6eb327e94/security/sandbox/chromium/base/environment.cc#L29-L42
Firefox only do this when default one not found. Besides, lowercase http_proxy is more widely recognized.
does not read HTTP_PROXY (all caps) or `HtTp_PrOxY" or w/e.
For Windows, environment variable are case-insensitive. But for linux it is case-sensitive: but still, only http_proxy or HTTP_PROXY are valid but not all combinations :)
servo-highfive
added
S-needs-code-changes
Co-authored-by: Euclid Ye <[email protected]> Signed-off-by: tho <[email protected]>
servo-highfive
added
S-awaiting-review
yezhizhen
approved these changes
Dec 15, 2025
servo-highfive
removed
the
S-awaiting-review
Signed-off-by: Euclid Ye <[email protected]>
servo-highfive
added
the
S-awaiting-review
yezhizhen
changed the title
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow up to #41209
#41209 does not read HTTP_PROXY (all caps) or `HtTp_PrOxY" or w/e. i personally have the variable in all caps. I propose we check both "HTTP_PROXY" and "http_proxy", but not mixed case. Firefox does just that at https://github.com/mozilla-firefox/firefox/blob/bef781bbd7a225c428c2444d7d02e9f6eb327e94/security/sandbox/chromium/base/environment.cc#L29-L42