script: Add an initial command and commandfor attribute implementation#41237
script: Add an initial command and commandfor attribute implementation#41237TimvdLippe merged 1 commit intoservo:mainfrom
command and commandfor attribute implementation#41237Conversation
mrobinson
left a comment
There was a problem hiding this comment.
Looks pretty good! I have a few nits below. Do you want to keep working on this and get it ready to land?
|
🔨 Triggering try run (#20432672406) for Linux (WPT) |
|
|
|
Thanks for the review. I plan to pick it up in January to get it finished off, so apologies for slow responses. This will need a stylo version bump to compile too. |
0073e9c to
fb96dd8
Compare
|
🔨 Triggering try run (#21412269068) for Linux (WPT) |
fb96dd8 to
84b03b4
Compare
|
🔨 Triggering try run (#21412643366) for Linux (WPT) |
84b03b4 to
99425fc
Compare
|
Test results for linux-wpt from try job (#21412269068): Flaky unexpected result (34)
Stable unexpected results that are known to be intermittent (27)
|
|
✨ Try run (#21412269068) succeeded. |
|
Test results for linux-wpt from try job (#21412643366): Flaky unexpected result (29)
Stable unexpected results that are known to be intermittent (25)
|
|
✨ Try run (#21412643366) succeeded. |
mrobinson
left a comment
There was a problem hiding this comment.
On question here about finding a node with the same id:
99425fc to
6f53442
Compare
|
🔨 Triggering try run (#22348146319) for Linux (WPT) |
|
Test results for linux-wpt from try job (#22348146319): Flaky unexpected result (28)
Stable unexpected results that are known to be intermittent (19)
|
|
✨ Try run (#22348146319) succeeded. |
command and commandfor attribute implementation
ed3eded to
2becb1b
Compare
Signed-off-by: Luke Warlow <[email protected]>
2becb1b to
301e17e
Compare
…ation (#41237) Initial command and commandfor attribute implementation Testing: Covered by WPTs Signed-off-by: Luke Warlow <[email protected]>
…ation (servo#41237) Initial command and commandfor attribute implementation Testing: Covered by WPTs Signed-off-by: Luke Warlow <[email protected]>
Initial command and commandfor attribute implementation
Testing: Covered by WPTs