servoshell: Use WheelMode::DeltaPixel on line-based wheel events converted to pixels#41184
Merged
mrobinson merged 1 commit intoservo:mainfrom Dec 10, 2025
Merged
Conversation
…nverted to pixels servoshell is converting line-based wheel scrolls to pixels, so we need to send `WheelMode::DeltaPixel` in with the value. This value is processed directly by script and is the way it interprets the delta. A better fix here would be to actually process these values fully in script, but that is aved for a followup. Signed-off-by: Martin Robinson <[email protected]>
servo-highfive
added
the
S-awaiting-review
atbrakhi
approved these changes
Dec 10, 2025
servo-highfive
removed
the
S-awaiting-review
servo-highfive
added
the
S-awaiting-merge
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 10, 2025
…nverted to pixels (#41184) servoshell is converting line-based wheel scrolls to pixels, so we need to send `WheelMode::DeltaPixel` in with the value. This value is processed directly by script and is the way it interprets the delta. A better fix here would be to actually process these values fully in script, but that is aved for a followup. Testing: This part of servoshell is untested, so it's difficult to add a test for this. Fixes: #41164. Signed-off-by: Martin Robinson <[email protected]>
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
servo-highfive
added
S-tests-failed
servo-highfive
added
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
servoshell is converting line-based wheel scrolls to pixels, so we need
to send
WheelMode::DeltaPixelin with the value. This value isprocessed directly by script and is the way it interprets the delta.
A better fix here would be to actually process these values fully in
script, but that is aved for a followup.
Testing: This part of servoshell is untested, so it's difficult to add
a test for this.
Fixes: #41164.