layout: Merge BaseFragment and BaseFragmentInfo#41177
Merged
Loirooriol merged 1 commit intoservo:mainfrom Dec 10, 2025
Merged
Conversation
servo-highfive
added
the
S-awaiting-review
mrobinson
approved these changes
Dec 10, 2025
Member
mrobinson
left a comment
mrobinson
left a comment
There was a problem hiding this comment.
Nice cleanup. There are some clippy errors, but otherwise this is great.
servo-highfive
removed
the
S-awaiting-review
These structs used to be different when they were added in servo#29699: `BaseFragment` had a `debug_id` field, while `BaseFragmentInfo` didn't. But this field was later removed in servo#35001, so the structs became identical. Therefore, this just unified them. I'm picking `BaseFragmentInfo` as the name, since it was the most frequently used of the two. Signed-off-by: Oriol Brufau <[email protected]>
Loirooriol
force-pushed
the
base-fragment
branch
from
d464854 to
4217911
Compare
servo-highfive
added
the
S-awaiting-review
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These structs used to be different when they were added in #29699:
BaseFragmenthad adebug_idfield, whileBaseFragmentInfodidn't. But this field was later removed in #35001, so the structs became identical.Therefore, this patch just unifies them. I'm picking
BaseFragmentInfoas the name, since it was the most frequently used of the two.Testing: Not needed, no change in behavior