Skip to content

Hacky accessibility tree for testing accesskit patch#41173

Closed
delan wants to merge 7 commits intomainfrom
hacky-accessibility-tree
Closed

Hacky accessibility tree for testing accesskit patch#41173
delan wants to merge 7 commits intomainfrom
hacky-accessibility-tree

Conversation

@delan
Copy link
Copy Markdown
Member

@delan delan commented Dec 10, 2025

Describe the changes that this pull request makes here. This will be the commit message.

Testing: Describe how this pull request is tested or why it doesn't require tests
Fixes: Link to an issue this pull requests fixes or remove this line if there is no issue

@delan
Copy link
Copy Markdown
Member Author

delan commented Dec 10, 2025 

$ git clone https://github.com/emilk/egui.git
$ ( cd egui; git checkout 0.33.2 )
$ git clone https://github.com/AccessKit/accesskit.git
$ ( cd accesskit; git checkout subtrees )

@delan delan force-pushed the hacky-accessibility-tree branch from f7fd041 to 297b364 Compare December 11, 2025 10:50
@lukewarlow
Copy link
Copy Markdown
Member

lukewarlow commented Dec 12, 2025 •
edited
Loading

Egui_patch_to_compile_servo_with_accesskit_subtrees.patch

A minimal patch to the egui checkout so it works with the accesskit subtree branch.

lukewarlow
lukewarlow reviewed Dec 12, 2025
View reviewed changes
@delan delan force-pushed the hacky-accessibility-tree branch 2 times, most recently from 516004a to 9a49939 Compare December 23, 2025 09:32
@delan delan mentioned this pull request Dec 23, 2025
Merged
@DataTriny
Copy link
Copy Markdown

DataTriny commented Dec 23, 2025

I finally spent some time building Servo and gave this patch a try on Windows. Using the NVDA screen reader, I can see widgets for the shell as well as the web page content in a document node. So far the subtree patch seem to technically work, I'll let you tell me how practical it is.

PS: If you could patch accesskit_windows in Cargo.toml, that would make it simpler for newcomers to also give this a try.

Looking forward to this new AccessKit integration. Happy to support you when needed.

@jdm jdm mentioned this pull request Dec 31, 2025
Open
@delan
Copy link
Copy Markdown
Member Author

delan commented Jan 6, 2026

PS: If you could patch accesskit_windows in Cargo.toml, that would make it simpler for newcomers to also give this a try.

done in 33ee78f :)

delan and others added 7 commits January 13, 2026 16:56
@delan @alice
Patch deps
463a1fc 
Co-authored-by: Alice Boxhall <[email protected]>
Signed-off-by: Delan Azabani <[email protected]>
@delan
Hacky accessibility tree for testing accesskit patch
eb90fcc 
Signed-off-by: Delan Azabani <[email protected]>
@delan @lukewarlow
Add some rough HTML element role mappings
08965f2 
Co-authored-by: Luke Warlow <[email protected]>
Signed-off-by: Delan Azabani <[email protected]>
@lukewarlow @delan
Send accessibility tree updates to accesskit
84798a5 
Signed-off-by: Luke Warlow <[email protected]>
Signed-off-by: Delan Azabani <[email protected]>
@alice @delan
Add accessibility mappings for h1-h6; remove several redundant mappings.
2b0b180 
Co-authored-by: Delan Azabani <[email protected]>
Signed-off-by: Alice Boxhall <[email protected]>
@delan
Fix crash when requesting text
6bab93a 
Signed-off-by: delan azabani <[email protected]>
@lukewarlow @delan
Print action requests from our subtree
64041ee 
Co-authored-by: Delan Azabani <[email protected]>
Signed-off-by: Luke Warlow <[email protected]>
@delan delan force-pushed the hacky-accessibility-tree branch from 6ac6a6b to 64041ee Compare January 13, 2026 09:22
@delan
Copy link
Copy Markdown
Member Author

delan commented Jan 13, 2026

rebased to servo main and egui 0.33.3 in 64041ee. old version was 6ac6a6b.

@delan delan mentioned this pull request Jan 14, 2026
Closed
9 tasks
@delan
Copy link
Copy Markdown
Member Author

delan commented Jan 14, 2026

closing in favour of #41137 :)

@delan delan closed this Jan 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@atbrakhi atbrakhi Awaiting requested review from atbrakhi atbrakhi will be requested when the pull request is marked ready for review atbrakhi is a code owner

@mrobinson mrobinson Awaiting requested review from mrobinson mrobinson will be requested when the pull request is marked ready for review mrobinson is a code owner

@Loirooriol Loirooriol Awaiting requested review from Loirooriol Loirooriol will be requested when the pull request is marked ready for review Loirooriol is a code owner

@jschwe jschwe Awaiting requested review from jschwe jschwe will be requested when the pull request is marked ready for review jschwe is a code owner

@gterzian gterzian Awaiting requested review from gterzian gterzian will be requested when the pull request is marked ready for review gterzian is a code owner

1 more reviewer

@lukewarlow lukewarlow lukewarlow left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@delan @lukewarlow @DataTriny @alice