constellation: Only set up a single Devtools route for all ScriptThreads#41161
Merged
atbrakhi merged 1 commit intoservo:mainfrom Dec 9, 2025
Merged
constellation: Only set up a single Devtools route for all ScriptThreads#41161atbrakhi merged 1 commit intoservo:mainfrom
ScriptThreads#41161atbrakhi merged 1 commit intoservo:mainfrom
Conversation
…ead`s Previously every `ScriptThread` had its own `DevTools` route, but we can share the same route amongst all of them. This should theoretically save file handles. The fact that this creating IPC routes is hidden a bit by the use of `GenericCallback`, but underneath it does actually create a route. Signed-off-by: Martin Robinson <[email protected]>
servo-highfive
added
the
S-awaiting-review
atbrakhi
approved these changes
Dec 9, 2025
servo-highfive
removed
the
S-awaiting-review
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously every
ScriptThreadhad its ownDevToolsroute, but we canshare the same route amongst all of them. This should theoretically save
file handles. The fact that this creating IPC routes is hidden a bit by
the use of
GenericCallback, but underneath it does actually create aroute.
Testing: This should not show any behavior differences and we do not test
for the number of file handles used.