libservo: Remove WebViewInner::rect#41156
Merged
mrobinson merged 1 commit intoservo:mainfrom Dec 9, 2025
Merged
Conversation
servo-highfive
added
the
S-awaiting-review
With the removal of the MDI support, a `WebView` is now always as big as the `RenderingContext` onto which it renders. This change removes the remnant of the MDI support which is the `rect` property. This was problematic because it could get out of sync with the size of the `RenderingContext`. This change also adds a test for the case where these could get out of sync. Signed-off-by: Martin Robinson <[email protected]>
mrobinson
force-pushed
the
remove-webview-rect
branch
from
25ba2de to
78a638e
Compare
mukilan
approved these changes
Dec 9, 2025
components/servo/webview.rs
Outdated
| } | ||
|
|
||
| pub fn notify_input_event(&self, event: InputEvent) -> InputEventId { | ||
| println!("notify: {event:?}"); |
Member
There was a problem hiding this comment.
Suggested change
| println!("notify: {event:?}"); |
Member
Author
There was a problem hiding this comment.
Removed in latest force push.
servo-highfive
removed
the
S-awaiting-review
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the removal of the MDI support, a
WebViewis now always as big asthe
RenderingContextonto which it renders. This change removes theremnant of the MDI support which is the
rectproperty. This wasproblematic because it could get out of sync with the size of the
RenderingContext.This change also adds a test for the case where these could get out of
sync.
Testing: There is a unit test for this change.
Closes: #41148.
Fixes: #41116.