libservo: Added set_rect method and called it in resize#41148
Closed
helvete003 wants to merge 1 commit intoservo:mainfrom
Closed
libservo: Added set_rect method and called it in resize#41148helvete003 wants to merge 1 commit intoservo:mainfrom
helvete003 wants to merge 1 commit intoservo:mainfrom
Conversation
servo-highfive
added
the
S-awaiting-review
helvete003
changed the title
|
🔨 Triggering try run (#20049307842) for Linux (WPT) |
jdm
reviewed
Dec 9, 2025
| self.inner().rect | ||
| } | ||
|
|
||
| pub fn set_rect(&self, new_size: Size2D<f32, DevicePixel>) { |
Member
There was a problem hiding this comment.
What is the benefit to making this a public API? When would an embedder be expected to call it?
| .servo | ||
| .compositor() | ||
| .resize_rendering_context(self.id(), new_size); | ||
| self.set_rect( |
Member
There was a problem hiding this comment.
My instinct here is that if we're only calling this new method in one place, we should just inline the method body instead and remove the method.
jdm
added
S-awaiting-answer
|
Test results for linux-wpt from try job (#20049307842): Flaky unexpected result (44)
Stable unexpected results that are known to be intermittent (14)
|
|
✨ Try run (#20049307842) succeeded. |
Member
|
I think it should be possible to write a unit test for this (eg. servo/components/servo/tests/webview.rs Line 263 in 7781b38 |
Member
|
I think the real fix here might be to do away with the |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 9, 2025
With the removal of the MDI support, a `WebView` is now always as big as the `RenderingContext` onto which it renders. This change removes the remnant of the MDI support which is the `rect` property. This was problematic because it could get out of sync with the size of the `RenderingContext`. This change also adds a test for the case where these could get out of sync. Testing: There is a unit test for this change. Closes: #41148. Fixes: #41116. Signed-off-by: Martin Robinson <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When resizing the
Servoshellwindow, therectof thewebviewwas not updated. This had the effect thatMouseEventslikemovewould not work outside of the old rect size.Testing: Open a website like wikipedia and resize the window. Hover over the text and check if the
Cursor::Texticon stays visible in the newly visible areas.Fixes: #41116 (comment)