Base: Implement GenericOneshot channels#41143
Merged
yezhizhen merged 1 commit intoservo:mainfrom Dec 9, 2025
Merged
Conversation
channel is restricted while in the Ipc Case we use the same IpcChannel (for now). We also use these channels in WebDriver to prove they work. Signed-off-by: Narfinger <[email protected]>
servo-highfive
added
the
S-awaiting-review
jdm
approved these changes
Dec 9, 2025
servo-highfive
removed
the
S-awaiting-review
yezhizhen
reviewed
Dec 9, 2025
servo-highfive
added
the
S-awaiting-merge
servo-highfive
removed
the
S-awaiting-merge
Member
|
I just stumbled upon this and the naming is confusing. Is this proper oneshot like we have in ipc-channel (meaning that it only support one connection) or is it bounded (like it is specified in the docs)? |
Contributor
Author
|
Oh I see. I guess I got confused by the name. The idea was that this is allowing only one message to go over and then self destructs. It looks like Ipc oneshot does something different. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements a GenericOneshot channel. The size in the crossbeam channel is restricted while in the Ipc case we use the same IpcChannel(for now).
We also use these channels in WebDriver to prove they work.
Testing: Unit Tests and compilation still works.
Fixes: #39019